fix: removal of temproary saml toggle

Author: ktyagiapphelix2u

common/djangoapps/third_party_auth/management/commands/tests/test_saml.py

@@ -5,17 +5,21 @@
 
 
 import os
+import importlib
 from io import StringIO
 
 from unittest import mock
 from ddt import ddt
 from django.contrib.sites.models import Site
 from django.core.management import call_command
 from django.core.management.base import CommandError
+from django.db.models import signals
 from requests import exceptions
 from requests.models import Response
 
 from openedx.core.djangolib.testing.utils import CacheIsolationTestCase, skip_unless_lms
+from common.djangoapps.third_party_auth.models import SAMLConfiguration
+from common.djangoapps.third_party_auth.signals import handlers
 from common.djangoapps.third_party_auth.tests.factories import SAMLConfigurationFactory, SAMLProviderConfigFactory
 
 
@@ -60,6 +64,10 @@ def setUp(self):
         """
         super().setUp()
 
+        # Disconnect signal handlers to prevent automatic provider config updates during test setup
+        # These tests manually create multiple versions of configs and expect specific counts
+        signals.post_save.disconnect(sender=SAMLConfiguration)
+
         self.stdout = StringIO()
         self.site = Site.objects.get_current()
         self.other_site = Site.objects.create(domain='other.example.com', name='Other Site')
@@ -81,6 +89,14 @@ def setUp(self):
             metadata_source='https://www.testshib.org/metadata/testshib-providers.xml',
         )
 
+    def tearDown(self):
+        """
+        Reconnect signal handlers after tests complete.
+        """
+        # Reconnect signals - Django will automatically re-register the handlers
+        importlib.reload(handlers)
+        super().tearDown()
+
     def _setup_test_configs_for_run_checks(self):
         """
         Helper method to create SAML configurations for run-checks tests.

common/djangoapps/third_party_auth/signals/tests/test_handlers.py

@@ -5,7 +5,7 @@
 import ddt
 from unittest import mock
 from unittest.mock import call
-from django.test import TestCase, override_settings
+from django.test import TestCase
 from django.contrib.sites.models import Site
 from common.djangoapps.third_party_auth.tests.factories import SAMLConfigurationFactory, SAMLProviderConfigFactory
 from common.djangoapps.third_party_auth.models import SAMLProviderConfig

common/djangoapps/third_party_auth/toggles.py

@@ -2,7 +2,7 @@
 Togglable settings for Third Party Auth
 """
 
-from edx_toggles.toggles import WaffleFlag, SettingToggle
+from edx_toggles.toggles import WaffleFlag
 
 THIRD_PARTY_AUTH_NAMESPACE = 'thirdpartyauth'