Ensure GeoMAD band names match the band name of C3 Landsat data.

[tebadi]

Currently the GeoMAD SR band names differ from Collection 3 NBART product. The issue was reported by Robbie :

where left is C3 Landsat band names and right is the current GeoMAD.

This fix is addressing the inconsistency issue.

[codecov]

Codecov Report

Merging #51 (7ed06af) into develop (3d014da) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop      #51   +/-   ##
========================================
  Coverage    62.41%   62.41%           
========================================
  Files           21       21           
  Lines         1998     1998           
========================================
  Hits          1247     1247           
  Misses         751      751           

Impacted Files	Coverage Δ
odc/stats/plugins/gm.py	65.78% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d014da...7ed06af. Read the comment docs.

[robbibt]

Looks great, thanks @tebadi! I imagine the band aliases themselves can be updated somewhere downstream/not in stats?
(in case we wanted to add the old names as aliases to match C3 Landsat)

[tebadi]

Yes, that will be changed in the product definitions Robbi.

[emmaai]

I don't think we need do this? We can just add aliases in the product definition as ARD products have been doing.

[tebadi]

I don't think we need do this? We can just add aliases in the product definition as ARD products have been doing.

This is fixing it at the source instead of fixing it downstream.

[emmaai]

If that’s the argument, then the input bands name should be fixed rather than hard mapping here. It was to take input band name as the output band name. The reason that we have seemingly different band names than what you preferred is because it loaded the bands by one of many aliases provided by ard. If it only loads the other aliases you like, it’ll give you the preferred band names.

Besides, this hard mapping is so fragile, slightly change on inputs bands name will render the whole thing broken, the same example that the input bands aliases change.

[tebadi]

If that’s the argument, then the input bands name should be fixed rather than hard mapping here. It was to take input band name as the output band name. The reason that we have seemingly different band names than what you preferred is because it loaded the bands by one of many aliases provided by ard. If it only loads the other aliases you like, it’ll give you the preferred band names.

I'd like fixing the band names to the preferred/output band names as opposed to adding alias here. It's more readable and achieves what we need for consistency between ARD and GeoMAD spectral bands. Done.