Commit e79f8dc
committed
runtime-config-linux: Clarify resources vs. cgroupsPath
This should help clarify the cgroupsPath setting added in #137, which
was the subject of some confusion in opencontainers/runc#397. Issues
I'm trying to clarify here:
* If you specify a cgroupsPath, is the container added to that path or
a sub-cgroup underneath it [1]? (This commit rules in favor of
"added to that path")
* If you specify a cgroupsPath, can the runtime modify that cgroup
[2]? (This commit rules "yes, if 'resources' is specified",
following [3] and the Go comment from #137 [4]).
To help make the distinctions clearer, I've added a facet list to help
folks think about the difference between cgroup creation, process
assignment, and resource configuration. cgroupsPath is just about
cgroup creation and process assignment. 'resources' is just about
resource configuration. I've listed out Mrunal's first three cases
[3] to be even clearer. I stayed away from the "neither are set"
case, since I covered that fairly directly in #237, which that was
punted back to the list [5] and has seen no further interest. So I'm
not clear on what the intended semantics are there, although Mrunal's
wording in [4] seems to agree with the proposal in #237.
[1]: opencontainers/runc#397 (comment)
[2]: opencontainers/runc#397 (comment)
[3]: opencontainers/runc#397 (comment)
[4]: 429f936#diff-34c30be66233f08b447fb608ea0e66bbR30
[5]: https://groups.google.com/a/opencontainers.org/d/msg/dev/qWHoKs8Fsrk/c9mv6qXtDAAJ
Message-ID: <[email protected]>
Signed-off-by: W. Trevor King <[email protected]>1 parent 7c17452 commit e79f8dc
1 file changed
Lines changed: 10 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
147 | 153 | | |
148 | 154 | | |
149 | 155 | | |
| |||
156 | 162 | | |
157 | 163 | | |
158 | 164 | | |
159 | | - | |
| 165 | + | |
160 | 166 | | |
161 | 167 | | |
162 | 168 | | |
163 | | - | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
164 | 172 | | |
165 | 173 | | |
166 | 174 | | |
| |||
0 commit comments