validate media types in manifest list

Signed-off-by: xiekeyang <[email protected]>

Author: xiekeyang

schema/validator.go

@@ -33,7 +33,8 @@ type Validator string
 type validateMediaTypeFunc func(r io.Reader, strict bool) error
 
 var mapValidateMediaTypes = map[Validator]validateMediaTypeFunc{
-	MediaTypeManifest: validateMediaTypeInManifest,
+	MediaTypeManifestList: validateMediaTypeInManifestList,
+	MediaTypeManifest:     validateMediaTypeInManifest,
 }
 
 // ValidationError contains all the errors that happened during validation.
@@ -92,6 +93,39 @@ func (v unimplemented) Validate(src io.Reader, strict bool) error {
 	return fmt.Errorf("%s: unimplemented", v)
 }
 
+func validateMediaTypeInManifestList(r io.Reader, strict bool) error {
+	header := v1.ManifestList{}
+
+	buf, err := ioutil.ReadAll(r)
+	if err != nil {
+		return errors.Wrapf(err, "error reading the io stream")
+	}
+
+	err = json.Unmarshal(buf, &header)
+	if err != nil {
+		return errors.Wrap(err, "manifest list format mismatch")
+	}
+
+	if header.MediaType != string(v1.MediaTypeImageManifestList) {
+		msg := fmt.Sprintf("manifest list has an unknown media type: %s", header.MediaType)
+		if strict {
+			return fmt.Errorf("%s", msg)
+		}
+		fmt.Printf("warning: %s\n", msg)
+	}
+
+	for _, manifest := range header.Manifests {
+		if manifest.MediaType != string(v1.MediaTypeImageManifest) {
+			msg := fmt.Sprintf("manifest %s has an unknown media type: %s", manifest.Digest, manifest.MediaType)
+			if strict {
+				return fmt.Errorf("%s", msg)
+			}
+			fmt.Printf("warning: %s\n", msg)
+		}
+	}
+	return nil
+}
+
 func validateMediaTypeInManifest(r io.Reader, strict bool) error {
 	header := v1.Manifest{}
 
@@ -106,7 +140,7 @@ func validateMediaTypeInManifest(r io.Reader, strict bool) error {
 	}
 
 	if header.MediaType != string(v1.MediaTypeImageManifest) {
-		msg := fmt.Sprintf("manifest has an unknown media type: %s\n", header.MediaType)
+		msg := fmt.Sprintf("manifest has an unknown media type: %s", header.MediaType)
 		if strict {
 			return fmt.Errorf("%s", msg)
 		}