Conversation
Member
robshakir
commented
Feb 3, 2022
* (M) client/client.go
* (M) client/client_test.go
* (M) compliance/election.go
* (M) compliance/flush.go
* (M) fluent/fluent.go
* (M) server/server.go
* (M) server/server_test.go
- adopt devel-v1.4.0 of gRIBI which changes the override argument
in a flush request to be an Empty vs. a boolean.
* (M) go.mod
* (M) go.sum
- update dependencies.
* (M) client/client_test.go
- Handle errors that can now be returned by FakeServer
initialisation.
* (M) compliance/compliance.go
* (M) compliance/compliance_test.go
* (M) compliance/flush.go
- Adopt a single VRF name as the non-default VRF and allow this to
be set by the client.
- initialise the fake/reference server with the set of VRFs that are
requested.
* (M) device/device.go
- Add an option to initialise the device with a set of VRFs.
* (M) server/server.go
* (M) server/server_test.go
- Allow the masterRIB to be initialised with a set of VRFs.
* (M) server/server_test.go
- Ensure we populate each RIB when initialising the server.
liulk
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.