Use codex-linux-sandbox in unified exec #6480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… ARM Add comments noting that the ctor logic for test binary aliasing is not supported on ARM architecture, and conditionally skip affected test on ARM targets.
bolinfest
reviewed
Nov 10, 2025
bolinfest
reviewed
Nov 10, 2025
bolinfest
reviewed
Nov 10, 2025
Move path entry and alias dispatch logic from arg0_dispatch_or_else to a new arg0_dispatch function, allowing reuse in test setup. Update tests to use arg0_dispatch directly. Fix minor regex in unified_exec test. Move 'ctor' dev-dependency to dev-dependencies only in core crate.
bolinfest
approved these changes
Nov 11, 2025
core: fix codex-windows-sandbox dependency name pty: add newline after env insertion for clarity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified exec isn't working on Linux because we don't provide the correct arg0.
The library we use for pty management doesn't allow setting arg0 separately from executable. Use the same aliasing strategy we use for
apply_patchforcodex-linux-sandbox.Use
#[ctor]hack to dispatch codex-linux-sandbox calls.Addresses #6450