Skip to content

MR Reads: Zero->NaN Padding #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2022
Merged

MR Reads: Zero->NaN Padding #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ openpmd_viewer.egg-info/
.cache/
.eggs/
.vs/
__pycache__
Copy link
Member Author

@ax3l ax3l Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added because they keep showing up in my git status

8 changes: 4 additions & 4 deletions openpmd_viewer/openpmd_timeseries/data_reader/io_reader/utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ def get_data(series, record_component, i_slice=None, pos_slice=None,
chunks = record_component.available_chunks()

if pos_slice is None:
# mask invalid regions with zero
data = np.zeros_like(record_component)
# mask invalid regions with NaN
data = np.full_like(record_component, np.nan)
for chunk in chunks:
chunk_slice = chunk_to_slice(chunk)
# read only valid region
Expand All @@ -76,8 +76,8 @@ def get_data(series, record_component, i_slice=None, pos_slice=None,
for dir_index in pos_slice_sorted: # remove indices in list
del slice_shape[dir_index]

# mask invalid regions with zero
data = np.zeros(slice_shape, dtype=output_type)
# mask invalid regions with NaN
data = np.full(slice_shape, np.nan, dtype=output_type)

# build requested ND slice with respect to full data
s = []
Expand Down