Don't check meshes or particles for dirty()

franzpoeschel · franzpoeschel · commit bfde8c5aabb3 · 2023-06-29T11:34:25.000+02:00
They're just aliases
diff --git a/src/CustomHierarchy.cpp b/src/CustomHierarchy.cpp
@@ -550,10 +550,10 @@ bool CustomHierarchy::dirtyRecursive() const
     {
         return true;
     }
-    if (particles.dirty() || meshes.dirty())
-    {
-        return true;
-    }
+    /*
+     * No need to check CustomHierarchy::particles or CustomHierarchy::meshes,
+     * since they are just aliases for subgroups.
+     */
     for (auto const &pair : particles)
     {
         if (pair.second.dirtyRecursive())

Original file line number	Diff line number	Diff line change
`@@ -550,10 +550,10 @@ bool CustomHierarchy::dirtyRecursive() const`
`550`	`550`	`{`
`551`	`551`	`return true;`
`552`	`552`	`}`
`553`		`- if (particles.dirty() \|\| meshes.dirty())`
`554`		`- {`
`555`		`- return true;`
`556`		`- }`
	`553`	`+ /*`
	`554`	`+ * No need to check CustomHierarchy::particles or CustomHierarchy::meshes,`
	`555`	`+ * since they are just aliases for subgroups.`
	`556`	`+ */`
`557`	`557`	`for (auto const &pair : particles)`
`558`	`558`	`{`
`559`	`559`	`if (pair.second.dirtyRecursive())`