Extend this test to variable-based

Author: franzpoeschel

CMakeLists.txt

@@ -811,6 +811,7 @@ if(openPMD_USE_INVASIVE_TESTS)
         message(WARNING "Invasive tests that redefine class signatures are "
                         "known to fail on Windows!")
     endif()
+    target_compile_definitions(openPMD PRIVATE openPMD_USE_INVASIVE_TESTS=1)
 endif()
 
 if(openPMD_BUILD_TESTING)

src/Iteration.cpp

@@ -549,6 +549,16 @@ void Iteration::read_impl(std::string const &groupPath)
     }
 
     readAttributes(ReadMode::FullyReread);
+#ifdef openPMD_USE_INVASIVE_TESTS
+    if (containsAttribute("__openPMD_internal_fail"))
+    {
+        throw error::ReadError(
+            error::AffectedObject::Attribute,
+            error::Reason::Other,
+            {},
+            "Deliberately failing this iteration for testing purposes");
+    }
+#endif
 }
 
 AdvanceStatus Iteration::beginStep()

test/SerialIOTest.cpp

@@ -5484,12 +5484,20 @@ TEST_CASE("no_explicit_flush", "[serial]")
     }
 }
 
-void unfinished_iteration_test(std::string const &file)
+#ifdef openPMD_USE_INVASIVE_TESTS
+void unfinished_iteration_test(
+    std::string const &ext, bool filebased, std::string const &config = "{}")
 {
+    std::string file = std::string("../samples/unfinished_iteration.") +
+        (filebased ? "_%T." : "") + ext;
     {
-        Series write(file, Access::CREATE);
+        Series write(file, Access::CREATE, config);
         auto it0 = write.writeIterations()[0];
-        it0.setAttribute("dt", "This is wrong.");
+        /*
+         * With enabled invasive tests, this attribute will let the Iteration
+         * fail parsing.
+         */
+        it0.setAttribute("__openPMD_internal_fail", "asking for trouble");
         auto it10 = write.writeIterations()[10];
         auto E_x = it10.meshes["E"]["x"];
         auto e_density = it10.meshes["e_density"][RecordComponent::SCALAR];
@@ -5505,11 +5513,17 @@ void unfinished_iteration_test(std::string const &file)
 TEST_CASE("unfinished_iteration_test", "[serial]")
 {
 #if openPMD_HAVE_ADIOS2
-    unfinished_iteration_test("../samples/unfinished_iteration.bp");
+    unfinished_iteration_test("bp", false);
     unfinished_iteration_test(
-        "../samples/unfinished_iteration_filebased_%T.bp");
+        "bp",
+        false,
+        R"(
+iteration_encoding = "variable_based"
+adios2.schema = 20210209)");
+    unfinished_iteration_test("bp", true);
 #endif
 }
+#endif
 
 TEST_CASE("late_setting_of_iterationencoding", "[serial]")
 {