Revert "Patch possible pybind11 bug"

franzpoeschel · franzpoeschel · commit 552175354ee1 · 2022-11-02T15:20:24.000+01:00
This reverts commit e5e9ae8.
diff --git a/share/openPMD/thirdParty/pybind11/include/pybind11/detail/class.h b/share/openPMD/thirdParty/pybind11/include/pybind11/detail/class.h
@@ -317,8 +317,8 @@ inline void register_instance(instance *self, void *valptr, const type_info *tin
 
 inline bool deregister_instance(instance *self, void *valptr, const type_info *tinfo) {
     bool ret = deregister_instance_impl(valptr, self);
-    // if (!tinfo->simple_ancestors)
-    //     traverse_offset_bases(valptr, tinfo, self, deregister_instance_impl);
+    if (!tinfo->simple_ancestors)
+        traverse_offset_bases(valptr, tinfo, self, deregister_instance_impl);
     return ret;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -317,8 +317,8 @@ inline void register_instance(instance self, void valptr, const type_info *tin`
`317`	`317`
`318`	`318`	`inline bool deregister_instance(instance self, void valptr, const type_info *tinfo) {`
`319`	`319`	`bool ret = deregister_instance_impl(valptr, self);`
`320`		`- // if (!tinfo->simple_ancestors)`
`321`		`- // traverse_offset_bases(valptr, tinfo, self, deregister_instance_impl);`
	`320`	`+ if (!tinfo->simple_ancestors)`
	`321`	`+ traverse_offset_bases(valptr, tinfo, self, deregister_instance_impl);`
`322`	`322`	`return ret;`
`323`	`323`	`}`
`324`	`324`