Skip to content

Conversation

@bachgarash
Copy link

@bachgarash bachgarash commented Nov 14, 2025

Fixes #2986

This PR introduces a new attribute - service.criticality

Relevant discussion has been made during Service and Deployment Semconv SIG meet

Meet notes https://docs.google.com/document/d/1Fy6yXfZqrwN_oHw95Bdfg_0hzUgzlk3VO5wA1invgkI/edit?tab=t.0

Recording can be found https://docs.google.com/spreadsheets/d/1SYKfjYhZdm2Wh2Cl6KVQalKg_m4NhTPZqq-8SzEVO6s/edit?gid=0#gid=0 (6th of November)

Changes

This PR introduces a new semantic convention attribute service.criticality to enable classification of services based on their operational importance. This attribute will allow observability platforms to implement criticality-aware tracing, and sampling strategies.

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@bachgarash
Copy link
Author

bachgarash commented Nov 14, 2025

Links to the prototypes or existing instrumentations (when adding or changing conventions)

I need help with guidance on how to provide prototype for a newly introduced semantic convention attribute. Please, feel free drop your idea. Thanks in advance!

@lmolkova lmolkova moved this from Untriaged to Awaiting codeowners approval in Semantic Conventions Triage Nov 17, 2025
@bachgarash bachgarash requested a review from a team as a code owner November 17, 2025 20:28
@jsuereth
Copy link
Contributor

Note: The build is failing - My approval is for the proposed change, but please clean up the build and get all tests to pass. I believe this needs a make table-generation registry-generation pass at a minimum, and possibly other cleanups .

@bachgarash bachgarash requested a review from jsuereth November 20, 2025 16:10
@bachgarash bachgarash requested a review from a team as a code owner November 27, 2025 18:03
@thompson-tomo
Copy link
Contributor

@bachgarash can you regenerate the docs to take on the changes to the documentation templates?

@bachgarash
Copy link
Author

Hi there. I have added a basic prototype into Otel-demo as requested

open-telemetry/opentelemetry-demo#2770

@bachgarash bachgarash force-pushed the feat/service-criticality-attribute branch from 9679b6a to 0de4ab4 Compare November 28, 2025 09:11
@bachgarash bachgarash requested review from a team as code owners November 28, 2025 09:11
@bachgarash bachgarash requested review from a team as code owners November 28, 2025 09:11
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@bachgarash bachgarash force-pushed the feat/service-criticality-attribute branch from 0de4ab4 to bf07d66 Compare November 28, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:service enhancement New feature or request

Projects

Status: Awaiting codeowners approval

Development

Successfully merging this pull request may close these issues.

New semconv attribute proposal - service.criticality

3 participants