Skip to content

[feature-flag] Replace error.type with feature_flag.error.type to match feature_flag.error.message #3452

@dyladan

Description

@dyladan

Area(s)

area:feature-flag

What's missing?

In #3308 error.message was deprecated in feature flag semconv in favor of the domain-specific feature_flag.error.message. The argument was that error.message was not grounded in any specific concept like exception.message and that it caused confusion between error log bodies and error.message attributes.

After talking with @beeme1mr, I propose that in the feature flag semconv we remove use of error.type for the same reasons, and to be consistent with other attributes in the feature flag semconv. I believe the only reason this was not done in #3308 is because error.type is stable, but the feature flag semconv doc is not yet stable so our use of it should still be subject to change.

Describe the solution you'd like

  • Remove error.type from model/feature-flags/events.yaml
  • Add feature_flag.error.type to model/feature-flags/registry.yaml and model/feature-flags/events.yaml

Tip

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    Need triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions