Skip to content

chore(deps): Updated zone.js version to support latest Angular #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

chore(deps): Updated zone.js version to support latest Angular #1930

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0846e84
updated zone.js version to support latest Angular
andriikovalenko-ideals Feb 8, 2024
ed02eaa
limited zone.js update version to ^0.14
andriikovalenko-ideals Feb 9, 2024
a78b636
empty commit to pass CLA check
andriikovalenko-ideals Feb 9, 2024
d925fda
updated package-lock.json
andriikovalenko-ideals Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metapackages/auto-instrumentations-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"peerDependencies": {
"@opentelemetry/api": "^1.3.0",
"zone.js": "0.11.4"
"zone.js": "^0.11.4"
Copy link
Member

@pichlermarc pichlermarc Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will allow for zone.js at >=0.11.4 and <0.12.0 - is that intended?
According to SemVer minor versions in a 0.x are considered breaking, therefore the caret does not do the same as with 1.x.

If you're trying to go to ^0.14.0 (Angular 17), please open a PR against the core repo first (related issue open-telemetry/opentelemetry-js#4445) - the dependency on zone.js here is transitive from there.

Copy link
Contributor Author

@AndrewAKovalenko AndrewAKovalenko Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you've already created PR open-telemetry/opentelemetry-js#4469
Thanks

I'll fix my PR to use same versions, as you do "zone.js": "^0.11.0 || ^0.13.0 || ^0.14.0"

Copy link
Member

@pichlermarc pichlermarc Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that sounds good.

Keep in mind, though, that we'll have to release the core repo first, then update the dependencies here, and once that's done we can merge this PR here. I'll take a few days.

Copy link
Contributor Author

@AndrewAKovalenko AndrewAKovalenko Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, not a problem

},
"devDependencies": {
"@babel/core": "7.22.17",
Expand Down
12 changes: 6 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion plugins/web/opentelemetry-instrumentation-long-task/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"webpack": "4.46.0",
"webpack-cli": "4.7.2",
"webpack-merge": "5.8.0",
"zone.js": "0.11.4"
"zone.js": "^0.11.4"
},
"dependencies": {
"@opentelemetry/core": "^1.8.0",
Expand Down
4 changes: 2 additions & 2 deletions plugins/web/opentelemetry-instrumentation-user-interaction/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"webpack": "4.46.0",
"webpack-cli": "4.7.2",
"webpack-merge": "5.8.0",
"zone.js": "0.11.4"
"zone.js": "^0.11.4"
},
"dependencies": {
"@opentelemetry/core": "^1.8.0",
Expand All @@ -86,7 +86,7 @@
},
"peerDependencies": {
"@opentelemetry/api": "^1.3.0",
"zone.js": "0.11.4"
"zone.js": "^0.11.4"
},
"sideEffects": false,
"homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/web/opentelemetry-instrumentation-user-interaction#readme"
Expand Down