Skip to content

Conversation

@macno
Copy link
Contributor

@macno macno commented Nov 9, 2023

Which problem is this PR solving?

Fixes #820

Short description of the changes

  • remove useless entries from files in package.json
  • add files in package.json where missing
  • remove .npmignore
  • fix typo in CONTRIBUTING.md

@macno macno requested a review from a team November 9, 2023 13:13
@macno macno force-pushed the cleanup-files-in-package-json branch 2 times, most recently from d4a82a7 to 6051ca3 Compare November 9, 2023 13:18
@macno macno force-pushed the cleanup-files-in-package-json branch from 6051ca3 to a709d7a Compare November 9, 2023 13:19
@macno macno changed the title Cleanup files in package json chore: cleanup files in package json Nov 9, 2023
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup! 💯

@codecov
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1786 (e67cd12) into main (e313938) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1786   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files         143      143           
  Lines        7301     7301           
  Branches     1460     1460           
=======================================
  Hits         6675     6675           
  Misses        626      626           

@MSNev
Copy link
Contributor

MSNev commented Nov 9, 2023

Why remove the .npmignore this stops unnecessary files getting included into the npm packages which just fill up the consumers disk space for no reason.

@macno
Copy link
Contributor Author

macno commented Nov 9, 2023

Why remove the .npmignore this stops unnecessary files getting included into the npm packages which just fill up the consumers disk space for no reason.

Hi @MSNev, .npmignore is not necessary since we whitelist what to include using the files property in the package.json

@blumamir blumamir merged commit 9b76ffb into open-telemetry:main Nov 13, 2023
jmcdo29 pushed a commit to jmcdo29/opentelemetry-js-contrib that referenced this pull request Nov 13, 2023
* chore: typo in CONTRIBUTING.md

* chore: cleanup files entries in package.json (open-telemetry#820)

* chore: add missing files entries to package.json (open-telemetry#820)

* chore: remove useless .npmignore (open-telemetry#820)

---------

Co-authored-by: Amir Blum <[email protected]>
@macno macno deleted the cleanup-files-in-package-json branch November 22, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set files field in all of our package.json files