Skip to content

Commit 2105609

Browse files
fix(instrumentation-generic-pool): update span name typo (#2405)
Should be 'generic-pool.acquire' instead of 'generic-pool.aquire' Signed-off-by: Kaung Zin Hein <[email protected]> Co-authored-by: Marc Pichler <[email protected]>
1 parent d7a5bd4 commit 2105609

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

plugins/node/opentelemetry-instrumentation-generic-pool/src/instrumentation.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export class GenericPoolInstrumentation extends InstrumentationBase {
109109
) {
110110
const parent = api.context.active();
111111
const span = instrumentation.tracer.startSpan(
112-
'generic-pool.aquire',
112+
'generic-pool.acquire',
113113
{},
114114
parent
115115
);
@@ -156,7 +156,7 @@ export class GenericPoolInstrumentation extends InstrumentationBase {
156156
}
157157
const parent = api.context.active();
158158
const span = instrumentation.tracer.startSpan(
159-
'generic-pool.aquire',
159+
'generic-pool.acquire',
160160
{},
161161
parent
162162
);

plugins/node/opentelemetry-instrumentation-generic-pool/test/index.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ describe('GenericPool instrumentation', () => {
9494
assert.strictEqual(await acquire(), CLIENT);
9595
const [span] = memoryExporter.getFinishedSpans();
9696
assert.strictEqual(memoryExporter.getFinishedSpans().length, 1);
97-
assert.strictEqual(span.name, 'generic-pool.aquire');
97+
assert.strictEqual(span.name, 'generic-pool.acquire');
9898
});
9999

100100
it('should attach it to the parent span', async () => {
@@ -107,7 +107,7 @@ describe('GenericPool instrumentation', () => {
107107
assert.strictEqual(memoryExporter.getFinishedSpans().length, 2);
108108

109109
const [span] = memoryExporter.getFinishedSpans();
110-
assert.strictEqual(span.name, 'generic-pool.aquire');
110+
assert.strictEqual(span.name, 'generic-pool.acquire');
111111
assert.strictEqual(span.parentSpanId, rootSpan.spanContext().spanId);
112112
});
113113
});

0 commit comments

Comments
 (0)