Skip to content

Commit 533c30a

Browse files
authored
Fix flaky MetricExporterConfigurationTest (#5877)
1 parent c39ebfe commit 533c30a

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

sdk-extensions/autoconfigure/src/testFullConfig/java/io/opentelemetry/sdk/autoconfigure/MetricExporterConfigurationTest.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,9 @@
3434

3535
class MetricExporterConfigurationTest {
3636

37-
private static final ConfigProperties EMPTY =
38-
DefaultConfigProperties.createFromMap(Collections.emptyMap());
37+
private static final ConfigProperties CONFIG_PROPERTIES =
38+
DefaultConfigProperties.createFromMap(
39+
Collections.singletonMap("otel.exporter.prometheus.port", "0"));
3940

4041
@RegisterExtension CleanupExtension cleanup = new CleanupExtension();
4142

@@ -48,7 +49,7 @@ void configureReader_PrometheusOnClasspath() {
4849

4950
MetricReader reader =
5051
MetricExporterConfiguration.configureReader(
51-
"prometheus", EMPTY, spiHelper, (a, b) -> a, closeables);
52+
"prometheus", CONFIG_PROPERTIES, spiHelper, (a, b) -> a, closeables);
5253
cleanup.addCloseables(closeables);
5354

5455
assertThat(reader).isInstanceOf(PrometheusHttpServer.class);
@@ -60,7 +61,7 @@ void configureReader_PrometheusOnClasspath() {
6061
void configureExporter_KnownSpiExportersOnClasspath(
6162
String exporterName, Class<? extends Closeable> expectedExporter) {
6263
NamedSpiManager<MetricExporter> spiExportersManager =
63-
MetricExporterConfiguration.metricExporterSpiManager(EMPTY, spiHelper);
64+
MetricExporterConfiguration.metricExporterSpiManager(CONFIG_PROPERTIES, spiHelper);
6465

6566
MetricExporter metricExporter =
6667
MetricExporterConfiguration.configureExporter(exporterName, spiExportersManager);
@@ -81,7 +82,7 @@ private static Stream<Arguments> knownExporters() {
8182
void configureMetricReader_KnownSpiExportersOnClasspath(
8283
String exporterName, Class<? extends Closeable> expectedExporter) {
8384
NamedSpiManager<MetricReader> spiMetricReadersManager =
84-
MetricExporterConfiguration.metricReadersSpiManager(EMPTY, spiHelper);
85+
MetricExporterConfiguration.metricReadersSpiManager(CONFIG_PROPERTIES, spiHelper);
8586

8687
MetricReader metricReader =
8788
MetricExporterConfiguration.configureMetricReader(exporterName, spiMetricReadersManager);

0 commit comments

Comments
 (0)