Skip to content

Conversation

@gnmeyer
Copy link

@gnmeyer gnmeyer commented Sep 25, 2025

@gnmeyer gnmeyer requested review from a team and puckpuck as code owners September 25, 2025 20:49
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@julianocosta89
Copy link
Member

@gnmeyer I'm a bit confused here.
Do we need all those new rendered files, just for the IPv6 example?
Isn't just this file enough?
https://github.com/open-telemetry/opentelemetry-helm-charts/pull/1872/files#diff-060f881c5ce99f9f5f8721f35c1e7c615d225ff40c17e3983a3c0d77057c0607

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 28, 2025
@iturgut
Copy link

iturgut commented Oct 29, 2025

The rendered files were made from the make generate-examples command as a target from the Makefile.
Looking at the other examples, they also have the rendered out files. Unless one of the workflows runs the make generate-examples command, all of these files should be fine to be merged in.

@julianocosta89
Copy link
Member

The rendered files were made from the make generate-examples command as a target from the Makefile. Looking at the other examples, they also have the rendered out files. Unless one of the workflows runs the make generate-examples command, all of these files should be fine to be merged in.

Yes, but that's because we are adding a "new" example.
My question is, do we need that new example?

I'm asking because every single example we add, we have hundreds of extra lines of code generated, that need to be maintained.

@TylerHelmuth
Copy link
Member

I agree we dont need a new example for this situation.

@iturgut
Copy link

iturgut commented Nov 10, 2025

Alright, that's fair. I reverted the example and kept the updates to the opentelemetry-demo/values.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants