Skip to content

Gracefully handle FixedSizeReservoir of size 0 #8232

@dashpole

Description

@dashpole

Description

I don't believe this is possible if using the reservoir through the SDK, but the current reservoir can panic if the size of the reservoir is 0.

Found by Copilot in #8230 (comment)

Expected behavior

The reservoir should not panic even if the size is 0.

Tip: React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions