Add ability for MinVer to version 1.0.0 for core projects #1774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddynaka
approved these changes
Feb 2, 2021
Codecov Report
@@ Coverage Diff @@
## main #1774 +/- ##
==========================================
+ Coverage 84.17% 84.19% +0.01%
==========================================
Files 187 187
Lines 5934 5934
==========================================
+ Hits 4995 4996 +1
+ Misses 939 938 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a MinVerTagPreix of "core-" to all the core projects. "Core" projects refers to the one which has an official spec https://github.com/open-telemetry/opentelemetry-specification currently marked "Stable". These projects are intended to be released as 1.0.0 soon.
Rest of the projects (instrumentation, extensions, opentracing shim etc) will remain in RC state, until their respective spec is marked stable and/or the project itself stabilizes.
(though it is releasing separately initially, the medium term we'd expect to release everything together with same version. and in long term, the instrumentations may even move out of this repo to elsewhere, likely current contrib repo or new dedicated per instrumentation repos.)