[Infra] Avoid interpolation for workflow scripts (#6865)

Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>

Author: martincostello

.github/workflows/Component.BuildTest.yml

@@ -51,6 +51,12 @@ jobs:
 
     runs-on: ${{ matrix.os }}
     timeout-minutes: 30
+
+    env:
+      PROJECT_NAME: ${{ inputs.project-name }}
+      PROJECT_BUILD_COMMANDS: ${{ inputs.project-build-commands }}
+      TARGET_FRAMEWORK: ${{ matrix.version }}
+
     steps:
     - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       with:
@@ -70,17 +76,20 @@ jobs:
       uses: actions/setup-dotnet@baa11fbfe1d6520db94683bd5c7a3818018e4309 # v5.1.0
 
     - name: dotnet restore ${{ inputs.project-name }}
-      run: dotnet restore ${{ inputs.project-name }} ${{ inputs.project-build-commands }}
+      shell: pwsh
+      run: dotnet restore ${env:PROJECT_NAME} ${env:PROJECT_BUILD_COMMANDS}
 
     - name: dotnet build ${{ inputs.project-name }}
-      run: dotnet build ${{ inputs.project-name }} --configuration Release --no-restore ${{ inputs.project-build-commands }}
+      shell: pwsh
+      run: dotnet build ${env:PROJECT_NAME} --configuration Release --no-restore ${env:PROJECT_BUILD_COMMANDS}
 
     - name: dotnet test ${{ inputs.project-name }}
+      shell: pwsh
       run: >
-        dotnet test ${{ inputs.project-name }}
+        dotnet test ${env:PROJECT_NAME}
         --collect:"Code Coverage"
         --results-directory:TestResults
-        --framework ${{ matrix.version }}
+        --framework ${env:TARGET_FRAMEWORK}
         --configuration Release
         --no-restore
         --no-build

.github/workflows/add-labels.yml

@@ -27,11 +27,12 @@ jobs:
           Import-Module .\build\scripts\add-labels.psm1
 
           AddLabelsOnIssuesForPackageFoundInBody `
-            -issueNumber ${{ github.event.issue.number }} `
+            -issueNumber ${env:ISSUE_NUMBER} `
             -issueBody $env:ISSUE_BODY
         env:
           GH_TOKEN: ${{ github.token }}
           ISSUE_BODY: ${{ github.event.issue.body }}
+          ISSUE_NUMBER: ${{ github.event.issue.number }}
 
   add-labels-on-pull-requests:
     permissions:
@@ -52,7 +53,8 @@ jobs:
           Import-Module .\build\scripts\add-labels.psm1
 
           AddLabelsOnPullRequestsBasedOnFilesChanged `
-            -pullRequestNumber ${{ github.event.pull_request.number }} `
+            -pullRequestNumber ${env:PR_NUMBER} `
             -labelPackagePrefix 'pkg:'
         env:
           GH_TOKEN: ${{ github.token }}
+          PR_NUMBER: ${{ github.event.pull_request.number }}

.github/workflows/automation.yml

@@ -30,10 +30,9 @@ jobs:
     outputs:
       enabled: ${{ steps.evaluate.outputs.enabled }}
 
-    env:
-      OTELBOT_DOTNET_PRIVATE_KEY_EXISTS: ${{ secrets.OTELBOT_DOTNET_PRIVATE_KEY != '' }}
-
     steps:
     - id: evaluate
+      env:
+        IS_ENABLED: ${{ secrets.OTELBOT_DOTNET_PRIVATE_KEY != '' }}
       run: |
-        echo "enabled=${{ env.OTELBOT_DOTNET_PRIVATE_KEY_EXISTS == 'true' }}" >> "$GITHUB_OUTPUT"
+        echo "enabled=$IS_ENABLED" >> "$GITHUB_OUTPUT"

.github/workflows/ci.yml

@@ -149,7 +149,9 @@ jobs:
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       - name: Run W3C Trace Context docker compose
-        run: docker compose --file=test/OpenTelemetry.Instrumentation.W3cTraceContext.Tests/docker-compose.yml --file=build/docker-compose.${{ matrix.version }}.yml --project-directory=. up --exit-code-from=tests --build
+        run: docker compose --file=test/OpenTelemetry.Instrumentation.W3cTraceContext.Tests/docker-compose.yml "--file=build/docker-compose.${FRAMEWORK_VERSION}.yml" --project-directory=. up --exit-code-from=tests --build
+        env:
+          FRAMEWORK_VERSION: ${{ matrix.version }}
 
   validate-packages:
     needs: detect-changes

.github/workflows/concurrency-tests.yml

@@ -27,7 +27,10 @@ jobs:
 
     - name: Run Coyote Tests
       shell: pwsh
-      run: .\build\scripts\test-threadSafety.ps1 -testProjectName ${{ matrix.project }} -targetFramework ${{ matrix.version }}
+      run: .\build\scripts\test-threadSafety.ps1 -testProjectName ${env:PROJECT_NAME} -targetFramework ${env:TARGET_FRAMEWORK}
+      env:
+        PROJECT_NAME: ${{ matrix.project }}
+        TARGET_FRAMEWORK: ${{ matrix.version }}
 
     - name: Publish Artifacts
       if: always() && !cancelled()

.github/workflows/verifyaotcompat.yml

@@ -26,4 +26,6 @@ jobs:
 
     - name: publish AOT testApp, assert static analysis warning count, and run the app
       shell: pwsh
-      run: .\build\scripts\test-aot-compatibility.ps1 ${{ matrix.version }}
+      run: .\build\scripts\test-aot-compatibility.ps1 ${env:TARGET_FRAMEWORK}
+      env:
+        TARGET_FRAMEWORK: ${{ matrix.version }}