Skip to content

Commit 7d8c403

Browse files
authored
IsAllDataRequested true after ending (#1758)
* IsAllDataRequested true after ending * false typo * Make it clear in comment that we are no marking IsAlLDataRequested as false
1 parent 4b14247 commit 7d8c403

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/OpenTelemetry/Trace/TracerProviderSdk.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,14 @@ internal TracerProviderSdk(
9797
return;
9898
}
9999

100+
// Spec says IsRecording must be false once span ends.
101+
// https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#isrecording
102+
// However, Activity has slightly different semantic
103+
// than Span and we don't have strong reason to do this
104+
// now, as Activity anyway allows read/write always.
105+
// Intentionally commenting the following line.
106+
// activity.IsAllDataRequested = false;
107+
100108
if (SuppressInstrumentationScope.DecrementIfTriggered() == 0)
101109
{
102110
this.processor?.OnEnd(activity);

0 commit comments

Comments
 (0)