[Infra] Suppress code analysis warnings (#6905)

Author: martincostello

docs/logs/extending-the-sdk/extending-the-sdk.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <NoWarn>$(NoWarn);CA2000;CA1848;CA1510;CA1305</NoWarn>
+    <NoWarn>$(NoWarn);CA2000;CA1848;CA1873;CA1510;CA1305</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

src/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs

@@ -78,13 +78,15 @@ public override ExportResult Export(in Batch<Activity> batch)
                 Content = new JsonContent(this, batch),
             };
 
+#pragma warning disable CA2025 // Do not pass 'IDisposable' instances into unawaited tasks
 #if NET
             using var response = this.synchronousSendSupportedByCurrentPlatform
             ? this.httpClient.Send(request, CancellationToken.None)
             : this.httpClient.SendAsync(request, CancellationToken.None).GetAwaiter().GetResult();
 #else
             using var response = this.httpClient.SendAsync(request, CancellationToken.None).GetAwaiter().GetResult();
 #endif
+#pragma warning restore CA2025 // Do not pass 'IDisposable' instances into unawaited tasks
 
             response.EnsureSuccessStatusCode();
 
@@ -211,9 +213,7 @@ public JsonContent(ZipkinExporter exporter, in Batch<Activity> batch)
 
 #if NET
         protected override void SerializeToStream(Stream stream, TransportContext? context, CancellationToken cancellationToken)
-        {
-            this.SerializeToStreamInternal(stream);
-        }
+            => this.SerializeToStreamInternal(stream);
 #endif
 
         protected override Task SerializeToStreamAsync(Stream stream, TransportContext? context)

test/Benchmarks/Logs/LogBenchmarks.cs

@@ -94,32 +94,28 @@ public void GlobalCleanup()
 
     [Benchmark]
     public void NoListenerStringInterpolation()
-    {
 #pragma warning disable CA2254 // Template should be a static expression
 #pragma warning disable CA1848 // Use the LoggerMessage delegates
-        this.loggerWithNoListener.LogInformation($"Hello from {FoodName} {FoodPrice}.");
+        => this.loggerWithNoListener.LogInformation($"Hello from {FoodName} {FoodPrice}.");
 #pragma warning restore CA1848 // Use the LoggerMessage delegates
 #pragma warning restore CA2254 // Template should be a static expression
-    }
 
     [Benchmark]
     public void NoListenerExtensionMethod()
-    {
 #pragma warning disable CA1848 // Use the LoggerMessage delegates
-        this.loggerWithNoListener.LogInformation("Hello from {Name} {Price}.", FoodName, FoodPrice);
+#pragma warning disable CA1873 // Avoid potentially expensive logging
+        => this.loggerWithNoListener.LogInformation("Hello from {Name} {Price}.", FoodName, FoodPrice);
+#pragma warning restore CA1873 // Avoid potentially expensive logging
 #pragma warning restore CA1848 // Use the LoggerMessage delegates
-    }
 
     [Benchmark]
-    public void NoListener()
-    {
+    public void NoListener() =>
         this.loggerWithNoListener.FoodRecallNotice(
                 brandName: "Contoso",
                 productDescription: "Salads",
                 productType: "Food & Beverages",
                 recallReasonDescription: "due to a possible health risk from Listeria monocytogenes",
                 companyName: "Contoso Fresh Vegetables, Inc.");
-    }
 
     [Benchmark]
     public void UnnecessaryIsEnabledCheck()
@@ -148,58 +144,46 @@ public void CreateLoggerRepeatedly()
     }
 
     [Benchmark]
-    public void OneProcessor()
-    {
+    public void OneProcessor() =>
         this.loggerWithOneProcessor.FoodRecallNotice(
                 brandName: "Contoso",
                 productDescription: "Salads",
                 productType: "Food & Beverages",
                 recallReasonDescription: "due to a possible health risk from Listeria monocytogenes",
                 companyName: "Contoso Fresh Vegetables, Inc.");
-    }
 
     [Benchmark]
-    public void BatchProcessor()
-    {
+    public void BatchProcessor() =>
         this.loggerWithBatchProcessor.FoodRecallNotice(
                 brandName: "Contoso",
                 productDescription: "Salads",
                 productType: "Food & Beverages",
                 recallReasonDescription: "due to a possible health risk from Listeria monocytogenes",
                 companyName: "Contoso Fresh Vegetables, Inc.");
-    }
 
     [Benchmark]
-    public void TwoProcessors()
-    {
+    public void TwoProcessors() =>
         this.loggerWithTwoProcessors.FoodRecallNotice(
                 brandName: "Contoso",
                 productDescription: "Salads",
                 productType: "Food & Beverages",
                 recallReasonDescription: "due to a possible health risk from Listeria monocytogenes",
                 companyName: "Contoso Fresh Vegetables, Inc.");
-    }
 
     [Benchmark]
-    public void ThreeProcessors()
-    {
+    public void ThreeProcessors() =>
         this.loggerWithThreeProcessors.FoodRecallNotice(
                 brandName: "Contoso",
                 productDescription: "Salads",
                 productType: "Food & Beverages",
                 recallReasonDescription: "due to a possible health risk from Listeria monocytogenes",
                 companyName: "Contoso Fresh Vegetables, Inc.");
-    }
 
-    internal sealed class NoopLogProcessor : BaseProcessor<LogRecord>
-    {
-    }
+    internal sealed class NoopLogProcessor : BaseProcessor<LogRecord>;
 
     internal sealed class NoopExporter : BaseExporter<LogRecord>
     {
         public override ExportResult Export(in Batch<LogRecord> batch)
-        {
-            return ExportResult.Success;
-        }
+            => ExportResult.Success;
     }
 }

test/OpenTelemetry.Tests/Logs/LogRecordTests.cs

@@ -12,6 +12,8 @@
 
 namespace OpenTelemetry.Logs.Tests;
 
+#pragma warning disable CA1873 // Avoid potentially expensive logging
+
 public sealed class LogRecordTests
 {
     private enum Field
@@ -1085,7 +1087,7 @@ public void CheckOriginalFormatAtArbitraryPosition(bool includeFormattedMessage,
 
     private static ILoggerFactory InitializeLoggerFactory(out List<LogRecord> exportedItems, Action<OpenTelemetryLoggerOptions>? configure = null)
     {
-        var items = exportedItems = new List<LogRecord>();
+        var items = exportedItems = [];
 
         return LoggerFactory.Create(builder =>
         {
@@ -1119,19 +1121,14 @@ public StructState(params KeyValuePair<string, object>[] items)
         public KeyValuePair<string, object> this[int index] => this.list[index];
 
         public IEnumerator<KeyValuePair<string, object>> GetEnumerator()
-        {
-            return this.list.GetEnumerator();
-        }
+            => this.list.GetEnumerator();
 
         IEnumerator IEnumerable.GetEnumerator()
-        {
-            return this.list.GetEnumerator();
-        }
+            => this.list.GetEnumerator();
     }
 
     internal sealed class DisposingState : IReadOnlyList<KeyValuePair<string, object?>>, IDisposable
     {
-        private string? value;
         private bool disposed;
 
         public DisposingState(string? value)
@@ -1154,9 +1151,9 @@ public string? Value
                 }
 #endif
 
-                return this.value;
+                return field;
             }
-            private set => this.value = value;
+            private set;
         }
 
         public KeyValuePair<string, object?> this[int index] => index switch
@@ -1168,9 +1165,7 @@ public string? Value
         };
 
         public void Dispose()
-        {
-            this.disposed = true;
-        }
+            => this.disposed = true;
 
         public IEnumerator<KeyValuePair<string, object?>> GetEnumerator()
         {
@@ -1200,7 +1195,7 @@ public override void OnEnd(LogRecord logRecord)
             }
             else if (this.fieldToUpdate == Field.StateValues)
             {
-                logRecord.StateValues = new List<KeyValuePair<string, object?>> { new("newStateValueKey", "newStateValueValue") };
+                logRecord.StateValues = [new("newStateValueKey", "newStateValueValue")];
             }
             else
             {
@@ -1219,14 +1214,10 @@ public ListState(params KeyValuePair<string, object>[] items)
         }
 
         public IEnumerator<KeyValuePair<string, object>> GetEnumerator()
-        {
-            return this.list.GetEnumerator();
-        }
+            => this.list.GetEnumerator();
 
         IEnumerator IEnumerable.GetEnumerator()
-        {
-            return this.list.GetEnumerator();
-        }
+            => this.list.GetEnumerator();
     }
 
     private sealed class CustomState
@@ -1248,7 +1239,7 @@ public ScopeProcessor(bool buffer)
             this.buffer = buffer;
         }
 
-        public List<object?> Scopes { get; } = new();
+        public List<object?> Scopes { get; } = [];
 
         public override void OnEnd(LogRecord data)
         {