-
Notifications
You must be signed in to change notification settings - Fork 358
Closed
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededinfraInfra work - CI/CD, code coverage, lintersInfra work - CI/CD, code coverage, linters
Description
We ran into an issue where a typo in a yml file (09cafa5) broke all code coverage upload.
I did a quick scan of GitHub marketplace, there seem to be some YML linters available. We should add linting of yml/yaml files into the CI.
High level we need to add a bucket for these files here:
| md: [ '**.md' ] |
yml: [ '**.yml, '**.yaml' ]
And then add a step for yml changes which calls some workflow to run linting. Similar to this...
opentelemetry-dotnet-contrib/.github/workflows/ci.yml
Lines 78 to 83 in dc7be37
| lint-md: | |
| needs: detect-changes | |
| if: | | |
| contains(needs.detect-changes.outputs.changes, 'md') | |
| || contains(needs.detect-changes.outputs.changes, 'build') | |
| uses: ./.github/workflows/markdownlint.yml |
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededinfraInfra work - CI/CD, code coverage, lintersInfra work - CI/CD, code coverage, linters