[Infra] Avoid interpolation for workflow scripts (#3849)

Author: martincostello

.github/workflows/Component.BuildTest.yml

@@ -55,6 +55,7 @@ jobs:
           version: net462
 
     runs-on: ${{ matrix.os }}
+    timeout-minutes: 45
 
     steps:
     - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -67,6 +68,8 @@ jobs:
     - name: Resolve project
       id: resolve-project
       shell: pwsh
+      env:
+        PROJECT_NAME: ${{ inputs.project-name }}
       run: |
         Import-Module .\build\scripts\build.psm1
 
@@ -79,7 +82,7 @@ jobs:
         $component = '' # Used to tell Component.proj what to build
 
         ResolveProject `
-          -projectNameOrComponentData '${{ inputs.project-name }}' `
+          -projectNameOrComponentData ${env:PROJECT_NAME} `
           -title ([ref]$title) `
           -project ([ref]$project) `
           -component ([ref]$component)
@@ -111,43 +114,57 @@ jobs:
       uses: actions/setup-dotnet@baa11fbfe1d6520db94683bd5c7a3818018e4309 # v5.1.0
 
     - name: dotnet restore ${{ steps.resolve-project.outputs.title }}
-      run: dotnet restore ${{ steps.resolve-project.outputs.project }} -p:EnablePackageValidation=true
+      run: dotnet restore ${env:PROJECT_PATH} -p:EnablePackageValidation=true
+      shell: pwsh
+      env:
+        PROJECT_PATH: ${{ steps.resolve-project.outputs.project }}
 
     - name: dotnet build ${{ steps.resolve-project.outputs.title }}
-      run: dotnet build ${{ steps.resolve-project.outputs.project }} --configuration Release --no-restore
+      run: dotnet build ${env:PROJECT_PATH} --configuration Release --no-restore
+      shell: pwsh
+      env:
+        PROJECT_PATH: ${{ steps.resolve-project.outputs.project }}
 
     - name: dotnet test ${{ steps.resolve-project.outputs.title }}
-      if: ${{ inputs.run-tests }}
+      if: inputs.run-tests
+      shell: pwsh
+      env:
+        PROJECT_PATH: ${{ steps.resolve-project.outputs.project }}
+        TARGET_FRAMEWORK: ${{ matrix.version }}
+        TEST_FILTER: ${{ inputs.test-case-filter }}
       run: >
         ${{ inputs.test-require-elevated && matrix.os != 'windows-latest' && 'sudo -E' || '' }}
-        dotnet test ${{ steps.resolve-project.outputs.project }}
+        dotnet test ${env:PROJECT_PATH}
         --collect:"Code Coverage"
         --results-directory:TestResults
-        --framework ${{ matrix.version }}
+        --framework ${env:TARGET_FRAMEWORK}
         --configuration Release
         --no-restore
         --no-build
         --logger:"console;verbosity=detailed"
         --logger:"GitHubActions;report-warnings=false"
         --logger:"junit;LogFilePath=TestResults/junit.xml"
-        --filter "${{ inputs.test-case-filter }}"
+        --filter "${env:TEST_FILTER}"
         -- RunConfiguration.DisableAppDomain=true
         ${{ inputs.test-require-elevated && matrix.os != 'windows-latest' && '&& sudo chmod a+rw ./TestResults' || '' }}
 
     - name: dotnet pack ${{ steps.resolve-project.outputs.title }}
-      if: ${{ matrix.os == 'windows-latest' && inputs.pack }}
-      run: dotnet pack ${{ steps.resolve-project.outputs.project }} --configuration Release --no-restore --no-build -p:EnablePackageValidation=true
+      if: matrix.os == 'windows-latest' && inputs.pack
+      run: dotnet pack ${env:PROJECT_PATH} --configuration Release --no-restore --no-build -p:EnablePackageValidation=true
+      shell: pwsh
+      env:
+        PROJECT_PATH: ${{ steps.resolve-project.outputs.project }}
 
     - name: Install coverage tool
-      if: ${{ inputs.run-tests }}
+      if: inputs.run-tests
       run: dotnet tool install -g dotnet-coverage
 
     - name: Merging test results
-      if: ${{ inputs.run-tests && hashFiles('./TestResults/**/*.coverage') != '' }}
+      if: inputs.run-tests && hashFiles('./TestResults/**/*.coverage') != ''
       run: dotnet-coverage merge -f cobertura -o ./TestResults/Cobertura.xml ./TestResults/**/*.coverage
 
     - name: Upload code coverage ${{ inputs.code-cov-prefix }}-${{ inputs.code-cov-name }}
-      if: ${{ inputs.run-tests && hashFiles('./TestResults/Cobertura.xml') != '' }}
+      if: inputs.run-tests && hashFiles('./TestResults/Cobertura.xml') != ''
       uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
       continue-on-error: true # Note: Don't fail for upload failures
       env:
@@ -175,7 +192,7 @@ jobs:
     - name: Publish ${{ steps.resolve-project.outputs.name }} NuGet packages to Artifacts
       uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
       # Only publish packages from the first job, which should be net462 for Windows in most cases, which is preferred for .NET Framework support
-      if: ${{ matrix.os == 'windows-latest' && inputs.pack && strategy.job-index == 0 }}
+      if: matrix.os == 'windows-latest' && inputs.pack && strategy.job-index == 0
       with:
         name: ${{ steps.resolve-project.outputs.name }}-packages
         path: ./artifacts/package/release

.github/workflows/automation.yml

@@ -28,10 +28,9 @@ jobs:
     outputs:
       enabled: ${{ steps.evaluate.outputs.enabled }}
 
-    env:
-      OTELBOT_DOTNET_CONTRIB_PRIVATE_KEY_EXISTS: ${{ secrets.OTELBOT_DOTNET_CONTRIB_PRIVATE_KEY != '' }}
-
     steps:
     - id: evaluate
+      env:
+        IS_ENABLED: ${{ secrets.OTELBOT_DOTNET_CONTRIB_PRIVATE_KEY != '' }}
       run: |
-        echo "enabled=${{ env.OTELBOT_DOTNET_CONTRIB_PRIVATE_KEY_EXISTS == 'true' }}" >> "$GITHUB_OUTPUT"
+        echo "enabled=$IS_ENABLED" >> "$GITHUB_OUTPUT"

.github/workflows/integration.yml

@@ -22,7 +22,9 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
       - name: Run redis docker compose
-        run: docker compose --file=test/OpenTelemetry.Instrumentation.StackExchangeRedis.Tests/docker-compose.yml --file=build/docker-compose.${{ matrix.version }}.yml --project-directory=. up --exit-code-from=tests --build
+        run: docker compose --file=test/OpenTelemetry.Instrumentation.StackExchangeRedis.Tests/docker-compose.yml "--file=build/docker-compose.${TARGET_FRAMEWORK}.yml" --project-directory=. up --exit-code-from=tests --build
+        env:
+          TARGET_FRAMEWORK: ${{ matrix.version }}
 
   kafka-integration-test:
     if: inputs.job == 'all' || inputs.job == 'kafka-integration-test'
@@ -35,7 +37,9 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
       - name: Run kafka docker compose
-        run: docker compose --file=test/OpenTelemetry.Instrumentation.ConfluentKafka.Tests/docker-compose.yml --file=build/docker-compose.${{ matrix.version }}.yml --project-directory=. up --exit-code-from=tests --build
+        run: docker compose --file=test/OpenTelemetry.Instrumentation.ConfluentKafka.Tests/docker-compose.yml "--file=build/docker-compose.${TARGET_FRAMEWORK}.yml" --project-directory=. up --exit-code-from=tests --build
+        env:
+          TARGET_FRAMEWORK: ${{ matrix.version }}
 
   cassandra-integration-test:
     if: inputs.job == 'all' || inputs.job == 'cassandra-integration-test'
@@ -48,4 +52,6 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
       - name: Run cassandra docker compose
-        run: docker compose --file=test/OpenTelemetry.Instrumentation.Cassandra.Tests/docker-compose.yml --file=build/docker-compose.${{ matrix.version }}.yml --project-directory=. up --exit-code-from=tests --build
+        run: docker compose --file=test/OpenTelemetry.Instrumentation.Cassandra.Tests/docker-compose.yml "--file=build/docker-compose.${TARGET_FRAMEWORK}.yml" --project-directory=. up --exit-code-from=tests --build
+        env:
+          TARGET_FRAMEWORK: ${{ matrix.version }}

.github/workflows/verifyaotcompat.yml

@@ -24,4 +24,6 @@ jobs:
 
     - name: publish AOT testApp, assert static analysis warning count, and run the app
       shell: pwsh
-      run: .\build\scripts\test-aot-compatibility.ps1 ${{ matrix.version }}
+      run: .\build\scripts\test-aot-compatibility.ps1 ${env:TARGET_FRAMEWORK}
+      env:
+        TARGET_FRAMEWORK: ${{ matrix.version }}