added some changes

msiddhu · msiddhu · commit cd1f9fc8dc97 · 2024-07-04T06:36:35.000Z
diff --git a/api/test/logs/logger_benchmark.cc b/api/test/logs/logger_benchmark.cc
@@ -16,18 +16,9 @@
 #include <benchmark/benchmark.h>
 
 using opentelemetry::logs::EventId;
-using opentelemetry::logs::Logger;
-using opentelemetry::logs::LoggerProvider;
 using opentelemetry::logs::Provider;
 using opentelemetry::logs::Severity;
-using opentelemetry::nostd::shared_ptr;
-using opentelemetry::nostd::span;
-using opentelemetry::nostd::string_view;
-
-namespace common  = opentelemetry::common;
-namespace nostd   = opentelemetry::nostd;
-namespace trace   = opentelemetry::trace;
-namespace log_api = opentelemetry::logs;
+
 
 namespace
 {
diff --git a/api/test/logs/logger_test.cc b/api/test/logs/logger_test.cc
@@ -16,11 +16,9 @@ using opentelemetry::logs::LoggerProvider;
 using opentelemetry::logs::Provider;
 using opentelemetry::logs::Severity;
 using opentelemetry::nostd::shared_ptr;
-using opentelemetry::nostd::span;
 using opentelemetry::nostd::string_view;
 namespace common = opentelemetry::common;
 namespace nostd  = opentelemetry::nostd;
-namespace trace  = opentelemetry::trace;
 
 // Check that the default logger is a noop logger instance
 TEST(Logger, GetLoggerDefault)
diff --git a/api/test/metrics/meter_provider_test.cc b/api/test/metrics/meter_provider_test.cc
@@ -6,7 +6,6 @@
 #include "opentelemetry/metrics/provider.h"
 #include "opentelemetry/nostd/shared_ptr.h"
 
-using opentelemetry::metrics::Meter;
 using opentelemetry::metrics::MeterProvider;
 using opentelemetry::metrics::NoopMeterProvider;
 using opentelemetry::metrics::Provider;
diff --git a/api/test/nostd/shared_ptr_test.cc b/api/test/nostd/shared_ptr_test.cc
@@ -88,7 +88,7 @@ TEST(SharedPtrTest, MoveConstructionFromStdSharedPtr)
 TEST(SharedPtrTest, Destruction)
 {
   bool was_destructed;
-  shared_ptr<A>{new A{was_destructed}};
+  shared_ptr<A>{new A{was_destructed}}; //NOLINT
   EXPECT_TRUE(was_destructed);
 }
 
diff --git a/api/test/trace/tracer_test.cc b/api/test/trace/tracer_test.cc
@@ -9,7 +9,6 @@
 
 namespace trace_api = opentelemetry::trace;
 namespace nostd     = opentelemetry::nostd;
-namespace context   = opentelemetry::context;
 
 TEST(TracerTest, GetCurrentSpan)
 {
diff --git a/examples/metrics_simple/metrics_ostream.cc b/examples/metrics_simple/metrics_ostream.cc
@@ -35,7 +35,6 @@
 #endif
 
 namespace metrics_sdk     = opentelemetry::sdk::metrics;
-namespace common          = opentelemetry::common;
 namespace exportermetrics = opentelemetry::exporter::metrics;
 namespace metrics_api     = opentelemetry::metrics;
 
diff --git a/examples/plugin/plugin/tracer.cc b/examples/plugin/plugin/tracer.cc
@@ -18,7 +18,6 @@
 namespace nostd   = opentelemetry::nostd;
 namespace common  = opentelemetry::common;
 namespace trace   = opentelemetry::trace;
-namespace context = opentelemetry::context;
 
 namespace
 {
diff --git a/exporters/memory/test/in_memory_span_data_test.cc b/exporters/memory/test/in_memory_span_data_test.cc
@@ -8,7 +8,6 @@
 #include <gtest/gtest.h>
 
 using opentelemetry::exporter::memory::InMemorySpanData;
-using opentelemetry::sdk::trace::Recordable;
 using opentelemetry::sdk::trace::SpanData;
 
 TEST(InMemorySpanData, AddRecordable)
diff --git a/exporters/ostream/test/ostream_metric_test.cc b/exporters/ostream/test/ostream_metric_test.cc
@@ -18,7 +18,6 @@
 #include <vector>
 
 namespace metric_sdk      = opentelemetry::sdk::metrics;
-namespace nostd           = opentelemetry::nostd;
 namespace exportermetrics = opentelemetry::exporter::metrics;
 
 TEST(OStreamMetricsExporter, Shutdown)
diff --git a/ext/src/http/client/curl/http_client_curl.cc b/ext/src/http/client/curl/http_client_curl.cc
@@ -542,7 +542,7 @@ bool HttpClient::doAbortSessions()
   }
 
   bool has_data = false;
-  for (auto session : pending_to_abort_sessions)
+  for (const auto& session : pending_to_abort_sessions)
   {
     if (!session.second)
     {
diff --git a/ext/test/http/curl_http_test.cc b/ext/test/http/curl_http_test.cc
@@ -12,6 +12,7 @@
 #include <fstream>
 #include <memory>
 #include <thread>
+#include <utility>
 #include <vector>
 
 #define HTTP_PORT 19000
@@ -74,7 +75,7 @@ class PostEventHandler : public CustomEventHandler
 class FinishInCallbackHandler : public CustomEventHandler
 {
 public:
-  FinishInCallbackHandler(std::shared_ptr<http_client::Session> session) : session_(session) {}
+  FinishInCallbackHandler(std::shared_ptr<http_client::Session> session) : session_(std::move(session)) {}
 
   void OnResponse(http_client::Response &response) noexcept override
   {
diff --git a/run-clang-tidy.sh b/run-clang-tidy.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
 
+# Copyright The OpenTelemetry Authors
+# SPDX-License-Identifier: Apache-2.0
+
 # Define the find command to exclude certain directories and find relevant files
 FIND='find . -name third_party -prune -o -name build -prune -o -name .git -prune -o -name "*.h" -o -name "*.cc" -print'
 
diff --git a/sdk/src/logs/logger.cc b/sdk/src/logs/logger.cc
@@ -30,8 +30,6 @@ namespace sdk
 {
 namespace logs
 {
-namespace trace_api = opentelemetry::trace;
-namespace common    = opentelemetry::common;
 
 Logger::Logger(
     opentelemetry::nostd::string_view name,
diff --git a/sdk/src/trace/batch_span_processor.cc b/sdk/src/trace/batch_span_processor.cc
@@ -29,7 +29,6 @@
 #include "opentelemetry/version.h"
 
 using opentelemetry::sdk::common::AtomicUniquePtr;
-using opentelemetry::sdk::common::CircularBuffer;
 using opentelemetry::sdk::common::CircularBufferRange;
 using opentelemetry::trace::SpanContext;
 
diff --git a/sdk/test/metrics/async_metric_storage_test.cc b/sdk/test/metrics/async_metric_storage_test.cc
@@ -29,7 +29,6 @@ using namespace opentelemetry::sdk::metrics;
 using namespace opentelemetry::sdk::instrumentationscope;
 using namespace opentelemetry::sdk::resource;
 using namespace opentelemetry::common;
-namespace nostd = opentelemetry::nostd;
 
 using M = std::map<std::string, std::string>;
 
diff --git a/sdk/test/metrics/attributes_hashmap_test.cc b/sdk/test/metrics/attributes_hashmap_test.cc
@@ -9,7 +9,6 @@
 #include <functional>
 
 using namespace opentelemetry::sdk::metrics;
-namespace nostd = opentelemetry::nostd;
 
 TEST(AttributesHashMap, BasicTests)
 {
diff --git a/sdk/test/metrics/sync_metric_storage_counter_test.cc b/sdk/test/metrics/sync_metric_storage_counter_test.cc
@@ -23,7 +23,6 @@
 using namespace opentelemetry::sdk::metrics;
 using namespace opentelemetry::common;
 using M         = std::map<std::string, std::string>;
-namespace nostd = opentelemetry::nostd;
 
 class WritableMetricStorageTestFixture : public ::testing::TestWithParam<AggregationTemporality>
 {};
diff --git a/sdk/test/metrics/sync_metric_storage_histogram_test.cc b/sdk/test/metrics/sync_metric_storage_histogram_test.cc
@@ -22,7 +22,6 @@
 using namespace opentelemetry::sdk::metrics;
 using namespace opentelemetry::common;
 using M         = std::map<std::string, std::string>;
-namespace nostd = opentelemetry::nostd;
 
 class WritableMetricStorageHistogramTestFixture
     : public ::testing::TestWithParam<AggregationTemporality>
diff --git a/sdk/test/metrics/sync_metric_storage_up_down_counter_test.cc b/sdk/test/metrics/sync_metric_storage_up_down_counter_test.cc
@@ -21,7 +21,6 @@
 using namespace opentelemetry::sdk::metrics;
 using namespace opentelemetry::common;
 using M         = std::map<std::string, std::string>;
-namespace nostd = opentelemetry::nostd;
 
 class WritableMetricStorageTestFixture : public ::testing::TestWithParam<AggregationTemporality>
 {};
diff --git a/sdk/test/trace/tracer_test.cc b/sdk/test/trace/tracer_test.cc
@@ -20,7 +20,6 @@ using opentelemetry::common::SystemTimestamp;
 namespace nostd     = opentelemetry::nostd;
 namespace common    = opentelemetry::common;
 namespace trace_api = opentelemetry::trace;
-using opentelemetry::common::KeyValueIterableView;
 using opentelemetry::exporter::memory::InMemorySpanData;
 using opentelemetry::exporter::memory::InMemorySpanExporter;
 using opentelemetry::trace::SpanContext;

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ TEST(SharedPtrTest, MoveConstructionFromStdSharedPtr)`
`88`	`88`	`TEST(SharedPtrTest, Destruction)`
`89`	`89`	`{`
`90`	`90`	`bool was_destructed;`
`91`		`- shared_ptr<A>{new A{was_destructed}};`
	`91`	`+ shared_ptr<A>{new A{was_destructed}}; //NOLINT`
`92`	`92`	`EXPECT_TRUE(was_destructed);`
`93`	`93`	`}`
`94`	`94`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@`
`9`	`9`
`10`	`10`	`namespace trace_api = opentelemetry::trace;`
`11`	`11`	`namespace nostd = opentelemetry::nostd;`
`12`		`-namespace context = opentelemetry::context;`
`13`	`12`
`14`	`13`	`TEST(TracerTest, GetCurrentSpan)`
`15`	`14`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`namespace nostd = opentelemetry::nostd;`
`19`	`19`	`namespace common = opentelemetry::common;`
`20`	`20`	`namespace trace = opentelemetry::trace;`
`21`		`-namespace context = opentelemetry::context;`
`22`	`21`
`23`	`22`	`namespace`
`24`	`23`	`{`
Original file line number	Diff line number	Diff line change
`@@ -542,7 +542,7 @@ bool HttpClient::doAbortSessions()`
`542`	`542`	`}`
`543`	`543`
`544`	`544`	`bool has_data = false;`
`545`		`- for (auto session : pending_to_abort_sessions)`
	`545`	`+ for (const auto& session : pending_to_abort_sessions)`
`546`	`546`	`{`
`547`	`547`	`if (!session.second)`
`548`	`548`	`{`