Skip to content

Conversation

@tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented May 12, 2020

We are planning on experimenting with logs data type in the Collector.
This commit introduces factories and components types for logs and
implements pipeline building for logs.

The data.Log struct is for now empty. We need to wait for OTLP protocol
to define the log data format and we will use it in data.Log.

data.Log is in internal package since logs support is experimental
and is not intended for public usage.

Resolves #957

@codecov-io
Copy link

codecov-io commented May 12, 2020

Codecov Report

Merging #959 into master will decrease coverage by 0.22%.
The diff coverage is 64.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
- Coverage   85.68%   85.45%   -0.23%     
==========================================
  Files         184      185       +1     
  Lines       13061    13181     +120     
==========================================
+ Hits        11191    11264      +73     
- Misses       1419     1461      +42     
- Partials      451      456       +5     
Impacted Files Coverage Δ
config/configmodels/configmodels.go 100.00% <ø> (+5.00%) ⬆️
internal/data/log.go 0.00% <0.00%> (ø)
processor/cloningfanoutconnector.go 69.44% <0.00%> (-9.51%) ⬇️
processor/fanoutconnector.go 82.85% <0.00%> (-10.70%) ⬇️
service/service.go 49.09% <0.00%> (ø)
service/builder/receivers_builder.go 73.98% <53.57%> (-4.39%) ⬇️
service/builder/exporters_builder.go 70.00% <61.90%> (+2.50%) ⬆️
service/builder/pipelines_builder.go 81.69% <68.75%> (-3.67%) ⬇️
config/config.go 99.70% <100.00%> (ø)
config/example_factories.go 87.65% <100.00%> (+2.80%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f588c89...5d21d46. Read the comment docs.

@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/log-datatype branch 2 times, most recently from ef5cf19 to 2504e50 Compare May 13, 2020 14:21
@tigrannajaryan tigrannajaryan changed the title [WIP] Add factories and component types to support logs data type Add factories and component types to support logs data type May 13, 2020
We are planning on experimenting with logs data type in the Collector.
This commit introduces factories and components types for logs and
implements pipeline building for logs.

The data.Log struct is for now empty. We need to wait for OTLP protocol
to define the log data format and we will use it in data.Log.

data.Log is in internal package since logs support is experimental
and is not intended for public usage yet.

Resolves open-telemetry#957
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/log-datatype branch from 2504e50 to 5d21d46 Compare May 13, 2020 19:41
@tigrannajaryan tigrannajaryan merged commit 0a58f78 into open-telemetry:master May 13, 2020
@tigrannajaryan tigrannajaryan deleted the feature/tigran/log-datatype branch May 13, 2020 20:58
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
…emetry#959)

We are planning on experimenting with logs data type in the Collector.
This commit introduces factories and components types for logs and
implements pipeline building for logs.

The data.Log struct is for now empty. We need to wait for OTLP protocol
to define the log data format and we will use it in data.Log.

data.Log is in internal package since logs support is experimental
and is not intended for public usage yet.

Resolves open-telemetry#957
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add log data type to begin experimenting with logs support

4 participants