-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add factories and component types to support logs data type #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tigrannajaryan
merged 1 commit into
open-telemetry:master
from
tigrannajaryan:feature/tigran/log-datatype
May 13, 2020
Merged
Add factories and component types to support logs data type #959
tigrannajaryan
merged 1 commit into
open-telemetry:master
from
tigrannajaryan:feature/tigran/log-datatype
May 13, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89e48d6 to
efe4df6
Compare
Codecov Report
@@ Coverage Diff @@
## master #959 +/- ##
==========================================
- Coverage 85.68% 85.45% -0.23%
==========================================
Files 184 185 +1
Lines 13061 13181 +120
==========================================
+ Hits 11191 11264 +73
- Misses 1419 1461 +42
- Partials 451 456 +5
Continue to review full report at Codecov.
|
ef5cf19 to
2504e50
Compare
bogdandrutu
approved these changes
May 13, 2020
We are planning on experimenting with logs data type in the Collector. This commit introduces factories and components types for logs and implements pipeline building for logs. The data.Log struct is for now empty. We need to wait for OTLP protocol to define the log data format and we will use it in data.Log. data.Log is in internal package since logs support is experimental and is not intended for public usage yet. Resolves open-telemetry#957
2504e50 to
5d21d46
Compare
dmitryax
approved these changes
May 13, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
…emetry#959) We are planning on experimenting with logs data type in the Collector. This commit introduces factories and components types for logs and implements pipeline building for logs. The data.Log struct is for now empty. We need to wait for OTLP protocol to define the log data format and we will use it in data.Log. data.Log is in internal package since logs support is experimental and is not intended for public usage yet. Resolves open-telemetry#957
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are planning on experimenting with logs data type in the Collector.
This commit introduces factories and components types for logs and
implements pipeline building for logs.
The data.Log struct is for now empty. We need to wait for OTLP protocol
to define the log data format and we will use it in data.Log.
data.Log is in internal package since logs support is experimental
and is not intended for public usage.
Resolves #957