Skip to content

Conversation

@owais
Copy link
Contributor

@owais owais commented Mar 30, 2020

Description:
Pushing release tags will automatically create Github releases with binaries and a checksum file as release artifacts. The release engineer will need to prepare release notes in advance and update the body of the automatically created release manually after the CI job finishes.

Testing: Tested locally and on CI with my fork.

@bogdandrutu
Copy link
Member

bogdandrutu commented Mar 30, 2020

@owais looks like you have some specific setup that circleci does not trigger on the PRs that you posted, it works for everyone else, can you take a look?

Copy link
Contributor

@flands flands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owais
Copy link
Contributor Author

owais commented Mar 30, 2020

Yes, looking into the same. I think it might be because I also build my fork in CircleCI. Circle probably builds my branches there instead of here. Will disable my fork in Circle and see if that helps.

@bogdandrutu
Copy link
Member

@owais works now :)

@tigrannajaryan
Copy link
Member

I am not sure I fully understand the change.

Before this the releases looked like this:

  1. Go to Github Releases page.
  2. Click "new release: button , type release notes and publish it.
  3. CircleCI builds and publishes to Dockerhub.

What changes after this PR?

Now we'll automatically create Github releases from tags and upload the
binaries and their checksums as release artifacts.
@owais
Copy link
Contributor Author

owais commented Mar 30, 2020

@tigrannajaryan Not much changes. Before the workflow was something like this:

  1. Create draft release with notes.
  2. Create git tag and push tag to github
  3. CircleCI automatically publishes docker images
  4. Publish draft release

After this PR it'll be the following

  1. Prepare draft release notes in GH/slack/local.
  2. Create git tag and push to github.
  3. CircleCI will publish images to docker hub, create a new release on Github for the tag, upload all binaries built to the CircleCI release as build artifacts along with a file containing checksum of each build.
  4. Edit the automatically created release and paste release notes you prepared in step 1.

The purpose was to automatically upload built binaries as release artifacts along with checksum information. The tool does not have a way to update an existing draft release with the artifacts. If we feel we really want to create draft release notes in GH before pushing the tag and then have Circle publish artifacts to the same, we can add support for it later.

@codecov-io
Copy link

Codecov Report

Merging #745 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   84.58%   84.60%   +0.01%     
==========================================
  Files         162      162              
  Lines       11650    11650              
==========================================
+ Hits         9854     9856       +2     
+ Misses       1394     1393       -1     
+ Partials      402      401       -1     
Impacted Files Coverage Δ
translator/internaldata/resource_to_oc.go 73.13% <0.00%> (ø)
receiver/opencensusreceiver/octrace/opencensus.go 93.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4c8a4...3cead5f. Read the comment docs.

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjanotti pjanotti merged commit 3c3de2b into open-telemetry:master Mar 30, 2020
@owais owais deleted the github-release-artifacts branch March 30, 2020 18:13
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Add UpDownCounter to the API

* Add an SDK test

* Comment fix
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants