-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Automate publishing of Github releases #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate publishing of Github releases #745
Conversation
|
@owais looks like you have some specific setup that circleci does not trigger on the PRs that you posted, it works for everyone else, can you take a look? |
flands
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Yes, looking into the same. I think it might be because I also build my fork in CircleCI. Circle probably builds my branches there instead of here. Will disable my fork in Circle and see if that helps. |
|
@owais works now :) |
|
I am not sure I fully understand the change. Before this the releases looked like this:
What changes after this PR? |
Now we'll automatically create Github releases from tags and upload the binaries and their checksums as release artifacts.
|
@tigrannajaryan Not much changes. Before the workflow was something like this:
After this PR it'll be the following
The purpose was to automatically upload built binaries as release artifacts along with checksum information. The tool does not have a way to update an existing draft release with the artifacts. If we feel we really want to create draft release notes in GH before pushing the tag and then have Circle publish artifacts to the same, we can add support for it later. |
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
+ Coverage 84.58% 84.60% +0.01%
==========================================
Files 162 162
Lines 11650 11650
==========================================
+ Hits 9854 9856 +2
+ Misses 1394 1393 -1
+ Partials 402 401 -1
Continue to review full report at Codecov.
|
pjanotti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add UpDownCounter to the API * Add an SDK test * Comment fix
Description:
Pushing release tags will automatically create Github releases with binaries and a checksum file as release artifacts. The release engineer will need to prepare release notes in advance and update the body of the automatically created release manually after the CI job finishes.
Testing: Tested locally and on CI with my fork.