Skip to content

Conversation

@pjanotti
Copy link
Contributor

Small refinements to the configsource interface:

  • Changing Retrieved to interface;
  • Separating the watching capability in a separate interface: WatchableRetrieved;
  • Adding a specific error to signal that the watched value was updated;

@pjanotti pjanotti requested a review from a team March 26, 2021 18:16
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #2821 (358f128) into main (acb3ae1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2821   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         290      290           
  Lines       15541    15541           
=======================================
  Hits        14242    14242           
  Misses        889      889           
  Partials      410      410           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb3ae1...358f128. Read the comment docs.

@bogdandrutu bogdandrutu merged commit c4108c1 into open-telemetry:main Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants