Update Prometheus to v2.19.2 #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilebox
requested review from
bogdandrutu,
dmitryax,
flands,
james-bebbington,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
nilebox
changed the title
nilebox
commented
Jul 9, 2020
| # Exclude some staticcheck messages | ||
| - linters: | ||
| - staticcheck | ||
| # See https://github.com/golang/protobuf/issues/1077 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
Extracted to #1308 since it's not related to Prometheus itself.
nilebox
commented
Jul 9, 2020
| // OcaStore is an interface combines io.Closer and prometheus' scrape.Appendable | ||
| type OcaStore interface { | ||
| scrape.Appendable | ||
| storage.Appendable |
Member
Author
There was a problem hiding this comment.
This interface change required manual implementation changes below.
nilebox
commented
Jul 9, 2020
|
|
||
| // returning an error from this method can cause the whole appending transaction to be aborted and fail | ||
| func (tr *transaction) AddFast(ls labels.Labels, _ uint64, t int64, v float64) error { | ||
| // always returns 0 to disable label caching |
Member
Author
There was a problem hiding this comment.
See https://github.com/prometheus/prometheus/blob/v2.19.2/storage/interface.go#L134
Returning 0 should lead to AddFast never being used.
This was referenced Jul 15, 2020
Closed
Contributor
|
@nilebox is this still WIP or ready for review? |
Member
Author
Member
|
@nilebox can you work on this? |
Member
Author
|
@bogdandrutu yep, I will update this PR and see if there are any other problems blocking it. |
Codecov Report
@@ Coverage Diff @@
## master #1301 +/- ##
=======================================
Coverage 90.28% 90.28%
=======================================
Files 232 232
Lines 16396 16396
=======================================
Hits 14803 14803
- Misses 1136 1137 +1
+ Partials 457 456 -1
Continue to review full report at Codecov.
|
nilebox
changed the title
bogdandrutu
approved these changes
Jul 24, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…etry#1301) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.32.0 to 1.32.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.32.0...v1.32.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
…elemetry#1301) Signed-off-by: owent <[email protected]>
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
…rkaround null issue (open-telemetry#1301) * Allow alternate blank config * Fix template for older helm versions * remove debug template * Update values.yaml Co-authored-by: Dmitrii Anoshin <[email protected]> * bump version --------- Co-authored-by: Dmitrii Anoshin <[email protected]> Co-authored-by: Jared Tan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update prometheus to v2.19.2
Link to tracking Issue: Fixes #1124
Testing: Existing tests should cover potential regression
Documentation: -