Skip to content

testbed improvements #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2020
Merged

testbed improvements #1161

merged 2 commits into from
Jun 22, 2020

Conversation

@jrcamp
Copy link
Contributor

@jrcamp jrcamp commented Jun 22, 2020 •
edited
Loading

  • Use atomic wrappers for readability and for preventing accidentally accessing atomic variables
    non-atomically.
  • Enhance readability of large numbers in testbed by formatting with thousands separator.
  • Include rate per second in testbed output.

New output looks like:

2020/06/22 14:03:09 Starting load generator at 10000 items/sec.
2020/06/22 14:03:12 Agent RAM (RES):   1 MiB, CPU: 0.0% | Sent:   186,200 items | Received:   186,200 items (62,078/sec)
2020/06/22 14:03:15 Agent RAM (RES):  36 MiB, CPU:24.9% | Sent:   396,200 items | Received:   396,200 items (66,040/sec)
2020/06/22 14:03:18 Agent RAM (RES):  36 MiB, CPU:24.7% | Sent:   606,200 items | Received:   606,200 items (67,359/sec)
2020/06/22 14:03:21 Agent RAM (RES):  36 MiB, CPU:25.3% | Sent:   816,200 items | Received:   816,200 items (68,020/sec)
2020/06/22 14:03:24 Agent RAM (RES):  36 MiB, CPU:23.7% | Sent: 1,026,200 items | Received: 1,026,200 items (68,415/sec)

@jrcamp
testbed improvements
8ff666d 
* Use atomic wrappers for readability and for preventing accidentally accessing atomic variables
  non-atomically.
* Enhance readability of large numbers in testbed by formatting with thousands separator.
* Include rate per second in testbed output.
@tigrannajaryan tigrannajaryan self-assigned this Jun 22, 2020
@tigrannajaryan
Copy link
Member

tigrannajaryan commented Jun 22, 2020

Build failed.

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #1161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1161   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         201      201           
  Lines       14524    14524           
=======================================
  Hits        12620    12620           
  Misses       1454     1454           
  Partials      450      450

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1c0cb...43dda80. Read the comment docs.

@jrcamp
Copy link
Contributor Author

jrcamp commented Jun 22, 2020

@tigrannajaryan fixed

tigrannajaryan
tigrannajaryan approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tigrannajaryan tigrannajaryan merged commit a8db627 into open-telemetry:master Jun 22, 2020
@jrcamp jrcamp deleted the testbed branch June 22, 2020 19:16
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
@jrcamp @wyTrivail
Testbed improvements (open-telemetry#1161)
fbfbaca 
* Use atomic wrappers for readability and for preventing accidentally accessing atomic variables
  non-atomically.
* Enhance readability of large numbers in testbed by formatting with thousands separator.
* Include rate per second in testbed output.
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
@evantorrie @MrAlias @Aneurysm9
Add Skip Changelog label to Dependabot-sourced PRs (open-telemetry#1161)
34c02d1 
* Add "Skip Changelog" label to all dependabot PR requests

* Update CHANGELOG

* Include PR# in CHANGELOG

Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
@esigo
InMemorySpanExporter shutdown fix (open-telemetry#1161)
bb9d5de
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
@puckpuck
[demo] -Set flagd memory limit to 50Mi (open-telemetry#1161)
7b8b56e 
* Set flagd memory limit to 50Mi

Signed-off-by: Pierre Tessier <[email protected]>

* Set flagd memory limit to 50Mi

Signed-off-by: Pierre Tessier <[email protected]>

* generate examples after merge

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@dmitryax dmitryax Awaiting requested review from dmitryax

@flands flands Awaiting requested review from flands

@owais owais Awaiting requested review from owais

@pjanotti pjanotti Awaiting requested review from pjanotti

@rghetia rghetia Awaiting requested review from rghetia

@songy23 songy23 Awaiting requested review from songy23

1 more reviewer

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tigrannajaryan tigrannajaryan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrcamp @tigrannajaryan