remove opencensus bridge support #10406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10406 +/- ##
=======================================
Coverage 92.07% 92.08%
=======================================
Files 405 405
Lines 18862 18856 -6
=======================================
- Hits 17367 17363 -4
+ Misses 1135 1134 -1
+ Partials 360 359 -1 ☔ View full report in Codecov by Sentry. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
Author
|
not stale, still planning on moving this forward, just finishing up the blocking PR |
jpkrohling
approved these changes
Jul 3, 2024
Member
jpkrohling
left a comment
jpkrohling
left a comment
There was a problem hiding this comment.
Do we still have components using opencensus? I see two of them are mine, but I can commit to getting them migrated before the new release in two weeks.
Contributor
Author
There are 4 as listed in open-telemetry/opentelemetry-collector-contrib#29867 |
Contributor
Author
|
After discussing this further, i'll add a feature gate before this change. |
codeboten
force-pushed
the
codeboten/rm-opencensus
branch
from
5385591 to
01a59d2
Compare
codeboten
added a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Jul 4, 2024
This feature gate allows end users to re-enable the opencensus bridge if there's a need for it. This preceeds open-telemetry#10406 and will be taken out of draft once open-telemetry/opentelemetry-collector-contrib#29867 is completed. Signed-off-by: Alex Boten <[email protected]>
codeboten
added a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Jul 4, 2024
This feature gate allows end users to re-enable the opencensus bridge if there's a need for it. This preceeds open-telemetry#10406 and will be taken out of draft once open-telemetry/opentelemetry-collector-contrib#29867 is completed. Signed-off-by: Alex Boten <[email protected]>
Contributor
Author
|
This will stay in draft until #10542 has been merged and released. |
codeboten
added a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Jul 8, 2024
This feature gate allows end users to re-enable the opencensus bridge if there's a need for it. This preceeds open-telemetry#10406 and will be taken out of draft once open-telemetry/opentelemetry-collector-contrib#29867 is completed. Signed-off-by: Alex Boten <[email protected]>
codeboten
added a commit
that referenced
this pull request
Jul 9, 2024
This feature gate allows end users to re-enable the opencensus bridge if there's a need for it. This preceeds #10406 and will be taken out of draft once open-telemetry/opentelemetry-collector-contrib#29867 is completed. Related to #10414 --------- Signed-off-by: Alex Boten <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]>
codeboten
force-pushed
the
codeboten/rm-opencensus
branch
from
01a59d2 to
3d07cec
Compare
This removes the configuration of the OpenCensus bridge from the Collector. This means that any metric still relying on it will no longer be emitting metrics. This is blocked until open-telemetry/opentelemetry-collector-contrib#29867 is completed. Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/rm-opencensus
branch
from
3d07cec to
ceb32e7
Compare
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the configuration of the OpenCensus bridge from the Collector. This means that any metric still relying on it will no longer be emitting metrics.
Closes #10414
Closes #8945
This is blocked until open-telemetry/opentelemetry-collector-contrib#29867 is completed.