Reporting fatal error during shutdown process (even from async goroutine) deadlocks

[bogdandrutu]

The problem is that during shutdown the otelcol no longer looks for updates on the asyncErrorChannel, and if any component will try to write to that channel will get into a deadlock.

func (r *receiver) Start(_ context.Context, _ component.Host) error {
	r.server := &http.Server{
		Addr:           ":8080",
		Handler:        myHandler,
	}
	go func() {
		if err := r.server.ListenAndServe(); err != nil {
			// This is a small bug since err == http.ErrServerClosed is expected.
			r.settings.ReportStatus(component.NewFatalErrorEvent(err))
		}
	}()
	return nil
}

func (r *receiver) Shutdown(context.Context) error {
	if r.server == nil {
		return nil
	}
	return r.server.Close()
}

[spiffyy99]

Pointing out that this can also happen during startup or an update

basically whenever the control loop isn't actively running, components have free reign to call ReportStatus which will deadlock the caller goroutine.