Skip to content

Conversation

@jchengsfx
Copy link
Contributor

No description provided.

@jchengsfx jchengsfx requested a review from a team February 23, 2021 18:16
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #2535 (c47eed9) into main (49d0b61) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2535   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files         266      266           
  Lines       15111    15111           
=======================================
  Hits        13856    13856           
  Misses        871      871           
  Partials      384      384           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d0b61...c47eed9. Read the comment docs.

@jchengsfx jchengsfx force-pushed the release-v0.21.0 branch 2 times, most recently from 70c5840 to 6231f4c Compare February 24, 2021 16:14
@bogdandrutu bogdandrutu merged commit 7d7ae2e into open-telemetry:main Feb 24, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
The various propagation injectors will attempt to retrieve the
Span from the context that is provided in the api call:

  void Inject(context::propagation::TextMapCarrier &carrier,
              const context::Context &context) noexcept override

The shim will provide the RuntimeContext augmented with the baggage
to the Inject method. Unfortunately, the shim does not add the span
to the RuntimeContext. It does not instantiate a Scope.

This commit adds a Span to the context passed into Inject by
modifying the shim.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants