Added new semantic conventions #2365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willarmiros
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2365 +/- ##
==========================================
- Coverage 92.00% 92.00% -0.01%
==========================================
Files 272 272
Lines 15402 15401 -1
==========================================
- Hits 14170 14169 -1
Misses 850 850
Partials 382 382
Continue to review full report at Codecov.
|
Contributor
Author
|
Test failures seem to be unrelated transient issues. |
Member
|
Please rebase |
Contributor
Author
|
@bogdandrutu done :) |
bogdandrutu
approved these changes
Jan 20, 2021
bogdandrutu
requested changes
Jan 20, 2021
bogdandrutu
reviewed
Jan 20, 2021
bogdandrutu
approved these changes
Jan 22, 2021
bogdandrutu
approved these changes
Jan 22, 2021
This was referenced Mar 8, 2021
6 tasks
hughesjj
added a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…reported security issues (open-telemetry#2365)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Updates the conventions to include new resource attributes added to the official spec in open-telemetry/opentelemetry-specification#1099 and open-telemetry/opentelemetry-specification#1112. I put the AWS attributes in here because I feel that since they're part of the official spec, they should be codified in the collector repo. But I can move them to contrib if they're strongly not wanted.