Remove redundant code (#3155)

Author: rakyll

exporter/jaegerexporter/exporter.go

@@ -39,7 +39,6 @@ import (
 // The exporter name is the name to be used in the observability of the exporter.
 // The collectorEndpoint should be of the form "hostname:14250" (a gRPC target).
 func newTracesExporter(cfg *Config, logger *zap.Logger) (component.TracesExporter, error) {
-
 	opts, err := cfg.GRPCClientSettings.ToDialOptions()
 	if err != nil {
 		return nil, err
@@ -58,16 +57,14 @@ func newTracesExporter(cfg *Config, logger *zap.Logger) (component.TracesExporte
 		cfg.WaitForReady,
 		conn,
 	)
-	exp, err := exporterhelper.NewTracesExporter(
+	return exporterhelper.NewTracesExporter(
 		cfg, logger, s.pushTraceData,
 		exporterhelper.WithStart(s.start),
 		exporterhelper.WithShutdown(s.shutdown),
 		exporterhelper.WithTimeout(cfg.TimeoutSettings),
 		exporterhelper.WithRetry(cfg.RetrySettings),
 		exporterhelper.WithQueue(cfg.QueueSettings),
 	)
-
-	return exp, err
 }
 
 // protoGRPCSender forwards spans encoded in the jaeger proto

exporter/jaegerexporter/factory.go

@@ -59,16 +59,10 @@ func createTracesExporter(
 	expCfg := config.(*Config)
 	if expCfg.Endpoint == "" {
 		// TODO: Improve error message, see #215
-		err := fmt.Errorf(
+		return nil, fmt.Errorf(
 			"%q config requires a non-empty \"endpoint\"",
 			expCfg.ID().String())
-		return nil, err
 	}
 
-	exp, err := newTracesExporter(expCfg, params.Logger)
-	if err != nil {
-		return nil, err
-	}
-
-	return exp, nil
+	return newTracesExporter(expCfg, params.Logger)
 }