Skip to content

[exporter/azuremonitorexporter] Fix LogExporter correlation bug #9579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 2, 2022
Merged

[exporter/azuremonitorexporter] Fix LogExporter correlation bug #9579

merged 10 commits into from
May 2, 2022

Conversation

@cijothomas
Copy link
Member

@cijothomas cijothomas commented Apr 28, 2022 •
edited
Loading

Description: Fixes AzureMonitor Log Exporter correlation fields

  1. TraceId was already correctly mapped to operationId, but it was also added as custom property, which is not required. This removes adding TraceId as custom property.
  2. SpanId was incorrectly stored as custom property. This PR fixes it by correctly storing SpanId as OperationParentId.

Ref: https://github.com/microsoft/ApplicationInsights-dotnet/blob/main/BASE/src/Microsoft.ApplicationInsights/Extensibility/OperationCorrelationTelemetryInitializer.cs#L68

@cijothomas cijothomas requested review from a team and dashpole April 28, 2022 20:05
@cijothomas cijothomas changed the title Fix AzureMonitor LogExporter correlation [WIP] Fix AzureMonitor LogExporter correlation Apr 28, 2022
@cijothomas cijothomas changed the title [WIP] Fix AzureMonitor LogExporter correlation Fix AzureMonitor LogExporter correlation Apr 28, 2022
eedorenko
eedorenko suggested changes Apr 28, 2022
View reviewed changes
@cijothomas cijothomas changed the title Fix AzureMonitor LogExporter correlation [exporter/azuremonitorexporter] Fix LogExporter correlation bug Apr 29, 2022
@cijothomas
Copy link
Member Author

cijothomas commented Apr 29, 2022

@bogdandrutu Could you help merge this?

@codeboten codeboten merged commit 20793ad into open-telemetry:main May 2, 2022
@cijothomas cijothomas deleted the cijothomas/azmon_log_correlationfix branch May 2, 2022 16:44
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
@cijothomas @djaglowski
[exporter/azuremonitorexporter] Fix LogExporter correlation bug (open…
e829960 
…-telemetry#9579)

* Fix AzureMonitor LogExporter correlation

* Fix unwanted

* Fix test and add changelog

* Fix unused

* logrecord name

* logrecord name

* changelog

* chnagelog
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
@cijothomas cijothomas mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codeboten codeboten codeboten approved these changes

@dashpole dashpole Awaiting requested review from dashpole

+2 more reviewers

@pcwiese pcwiese pcwiese approved these changes

@eedorenko eedorenko eedorenko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bogdandrutu bogdandrutu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cijothomas @codeboten @pcwiese @eedorenko @bogdandrutu