[extension/awslogs_encoding] Add support for cloudwatch logs coming from subscription filter #38821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom subscription filter
atoulme
reviewed
Mar 21, 2025
| // Copyright The OpenTelemetry Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package subscriptionfilter // import "github.com/open-telemetry/opentelemetry-collector-contrib/extension/encoding/awslogsencodingextension/unmarshaler/subscription-filter" |
Contributor
There was a problem hiding this comment.
could you move this to an internal package?
Contributor
There was a problem hiding this comment.
The reason this is public is so other components can use the NewSubscriptionFilterUnmarshaler function directly. For example, this would enable us to remove the cwlog code in awsfirehosereceiver.
Rather than forcing users to configure an extension, there would be a special case where the receiver will instantiate the unmarshaler directly. We could also internally create an extension, but it seems a bit unnecessarily complicated.
atoulme
reviewed
Mar 21, 2025
...ion/encoding/awslogsencodingextension/unmarshaler/subscription-filter/subscription_filter.go
Outdated
Show resolved
Hide resolved
axw
reviewed
Mar 21, 2025
...ion/encoding/awslogsencodingextension/unmarshaler/subscription-filter/subscription_filter.go
Outdated
Show resolved
Hide resolved
...ion/encoding/awslogsencodingextension/unmarshaler/subscription-filter/subscription_filter.go
Outdated
Show resolved
Hide resolved
...ion/encoding/awslogsencodingextension/unmarshaler/subscription-filter/subscription_filter.go
Outdated
Show resolved
Hide resolved
atoulme
approved these changes
Mar 21, 2025
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…rom subscription filter (open-telemetry#38821) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Add support for [cloudwatch logs coming from subscription filter](https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/SubscriptionFilters.html). <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#38820 <!--Describe what testing was performed and which tests were added.--> #### Testing There are unit tests for new code. <!--Describe the documentation added.--> #### Documentation Comments and unit tests should be enough. <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for cloudwatch logs coming from subscription filter.
Link to tracking issue
#38820
Testing
There are unit tests for new code.
Documentation
Comments and unit tests should be enough.