[connector/servicegraph] Set MetricsExpirationLoop default to 60s #37966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehaansa
reviewed
Feb 18, 2025
JaredTan95
approved these changes
Feb 25, 2025
mapno
force-pushed
the
fix/servicegraph-excesive-writes
branch
from
159b546 to
21d0e8a
Compare
dehaansa
approved these changes
Mar 7, 2025
dehaansa
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes excessive writes to the servicegraph connector by setting a default expiration loop time of 60s.
Link to tracking issue
Fixes 34843
Testing
Updated testing to work with the new code.
Documentation
Updated config docs.