add external id config for role assumption #36725
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@binarymatt please sign the CLA. Would it make sense to update the respective exporters' docs, adding the new configuration option? Code owners please review. |
Contributor
Author
|
@andrzej-stencel i'm working on the CLA with my company today. I will look at updating the exporter docs as well, thanks. |
Contributor
Author
|
@andrzej-stencel when i took a look at some of the exporter docs and realized that various exporters do not include docs for |
github-actions
bot
added
exporter/awscloudwatchlogs
github-actions
bot
requested review from
boostchicken,
bryan-aguilar,
rapphil,
srprash and
wangzlei
This was referenced Dec 24, 2024
This was referenced Jan 7, 2025
Contributor
Author
|
is there anything i can do to move this along? |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
atoulme
pushed a commit
that referenced
this pull request
Mar 7, 2025
…assumption (#38062) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description When assuming a role in an external AWS account, there are cases where it's desirable to have an external id in the role assumption trust policy. This pull requests adds external id as an optional parameter when role assumption is used to retrieve AWS credentials. This is reopening this [pr](#36725) <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When assuming a role in an external AWS account, there are cases where it's desirable to have an external id in the role assumption trust policy. This pull requests adds external id as an optional parameter when role assumption is used to retrieve AWS credentials.