[exporter/datadog] Refactor WaitGroup into separate fields for traces and metrics exporter #33291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
reviewed
May 29, 2024
songy23
reviewed
May 29, 2024
Member
songy23
left a comment
songy23
left a comment
There was a problem hiding this comment.
This needs a changelog too as a bug fix
liustanley
force-pushed
the
stanley.liu/refactor-wg
branch
from
46ab774 to
14665bd
Compare
songy23
added
the
ready to merge
codeboten
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
TraceAgentis only called in the traces exporter andconsumeStatsPayloadis only called in the metrics exporter, so I think using the samewgfield was causing conflicts with both exporters in use at the same time. This PR splitswginto separate fields for each use case.This PR also removes
wg.Waiton the logs exporter since that wasn't applicable in the first place.Link to tracking Issue:
Testing:
Documentation: