more tests

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>

Author: odubajDT

internal/filter/filterconfig/config.go

@@ -130,7 +130,7 @@ var (
 	ErrInvalidLogField            = errors.New("services, span_names, span_kinds and metric_names are not valid for log records")
 	ErrMissingRequiredLogField    = errors.New(`at least one of "attributes", "libraries", "span_kinds", "resources", "log_bodies", "log_severity_texts" or "log_severity_number" field must be specified`)
 	ErrMissingRequiredMetricField = errors.New(`at least one of "metric_names" or "resources" field must be specified`)
-	ErrInvalidMetricField         = errors.New("span_names, span_kinds, resources, log_bodies, log_severity_texts, log_severity_number, services, attributes and libraries are not valid for metrics")
+	ErrInvalidMetricField         = errors.New(`"span_names", "span_kinds", "log_bodies", "log_severity_texts", "log_severity_number", "services", "attributes" and "libraries" are not valid for metrics`)
 
 	spanKinds = map[string]bool{
 		traceutil.SpanKindStr(ptrace.SpanKindInternal): true,

internal/filter/filterconfig/config_test.go

@@ -161,7 +161,7 @@ func Test_CreateMetricMatchPropertiesFromDefault(t *testing.T) {
 			want:    nil,
 		},
 		{
-			name: "invalid",
+			name: "invalid log bodies",
 			config: &MatchProperties{
 				MetricNames: []string{"kind"},
 				Config: filterset.Config{
@@ -172,6 +172,94 @@ func Test_CreateMetricMatchPropertiesFromDefault(t *testing.T) {
 			want:    nil,
 			wantErr: true,
 		},
+		{
+			name: "invalid log severity texts",
+			config: &MatchProperties{
+				MetricNames: []string{"kind"},
+				Config: filterset.Config{
+					MatchType: filterset.Regexp,
+				},
+				LogSeverityTexts: []string{"text"},
+			},
+			want:    nil,
+			wantErr: true,
+		},
+		{
+			name: "invalid log severity number",
+			config: &MatchProperties{
+				MetricNames: []string{"kind"},
+				Config: filterset.Config{
+					MatchType: filterset.Regexp,
+				},
+				LogSeverityNumber: &LogSeverityNumberMatchProperties{},
+			},
+			want:    nil,
+			wantErr: true,
+		},
+		{
+			name: "invalid span names",
+			config: &MatchProperties{
+				MetricNames: []string{"kind"},
+				Config: filterset.Config{
+					MatchType: filterset.Regexp,
+				},
+				SpanNames: []string{"text"},
+			},
+			want:    nil,
+			wantErr: true,
+		},
+		{
+			name: "invalid span kinds",
+			config: &MatchProperties{
+				MetricNames: []string{"kind"},
+				Config: filterset.Config{
+					MatchType: filterset.Regexp,
+				},
+				SpanKinds: []string{"text"},
+			},
+			want:    nil,
+			wantErr: true,
+		},
+		{
+			name: "invalid services",
+			config: &MatchProperties{
+				MetricNames: []string{"kind"},
+				Config: filterset.Config{
+					MatchType: filterset.Regexp,
+				},
+				Services: []string{"text"},
+			},
+			want:    nil,
+			wantErr: true,
+		},
+		{
+			name: "invalid attributes",
+			config: &MatchProperties{
+				MetricNames: []string{"kind"},
+				Config: filterset.Config{
+					MatchType: filterset.Regexp,
+				},
+				Attributes: []Attribute{
+					{Key: "key", Value: "val"},
+				},
+			},
+			want:    nil,
+			wantErr: true,
+		},
+		{
+			name: "invalid span kinds",
+			config: &MatchProperties{
+				MetricNames: []string{"kind"},
+				Config: filterset.Config{
+					MatchType: filterset.Regexp,
+				},
+				Libraries: []InstrumentationLibrary{
+					{Name: "name"},
+				},
+			},
+			want:    nil,
+			wantErr: true,
+		},
 		{
 			name: "valid",
 			config: &MatchProperties{