More explict testing testing for translation failures

Signed-off-by: Arthur Silva Sens <[email protected]>

Author: ArthurSens

exporter/prometheusremotewriteexporter/exporter_test.go

@@ -435,6 +435,8 @@ func Test_PushMetrics(t *testing.T) {
 
 	emptySummaryBatch := getMetricsFromMetricList(invalidMetrics[emptySummary])
 
+	metricWithInvalidTranslatedNameBatch := getMetricsFromMetricList(invalidMetrics[metricWithInvalidTranslatedName])
+
 	// partial success (or partial failure) cases
 
 	partialSuccess1 := getMetricsFromMetricList(validMetrics1[validSum], validMetrics2[validSum],
@@ -637,6 +639,13 @@ func Test_PushMetrics(t *testing.T) {
 			httpResponseCode:           http.StatusAccepted,
 			expectedFailedTranslations: 1,
 		},
+		{
+			name:                       "emptyMetricWithInvalidTranslatedName_case",
+			metrics:                    metricWithInvalidTranslatedNameBatch,
+			reqTestFunc:                checkFunc,
+			httpResponseCode:           http.StatusAccepted,
+			expectedFailedTranslations: 1,
+		},
 		{
 			name:                       "partialSuccess_case",
 			metrics:                    partialSuccess1,

exporter/prometheusremotewriteexporter/testutil_test.go

@@ -97,18 +97,20 @@ var (
 	emptySummary   = "emptySummary"
 
 	// Category 2: invalid type and temporality combination
-	emptyCumulativeSum       = "emptyCumulativeSum"
-	emptyCumulativeHistogram = "emptyCumulativeHistogram"
+	emptyCumulativeSum              = "emptyCumulativeSum"
+	emptyCumulativeHistogram        = "emptyCumulativeHistogram"
+	metricWithInvalidTranslatedName = "metricWithInvalidTranslatedName"
 
 	// different metrics that will not pass validate metrics and will cause the exporter to return an error
 	invalidMetrics = map[string]pmetric.Metric{
-		empty:                    pmetric.NewMetric(),
-		emptyGauge:               getEmptyGaugeMetric(emptyGauge),
-		emptySum:                 getEmptySumMetric(emptySum),
-		emptyHistogram:           getEmptyHistogramMetric(emptyHistogram),
-		emptySummary:             getEmptySummaryMetric(emptySummary),
-		emptyCumulativeSum:       getEmptyCumulativeSumMetric(emptyCumulativeSum),
-		emptyCumulativeHistogram: getEmptyCumulativeHistogramMetric(emptyCumulativeHistogram),
+		empty:                           pmetric.NewMetric(),
+		emptyGauge:                      getEmptyGaugeMetric(emptyGauge),
+		emptySum:                        getEmptySumMetric(emptySum),
+		emptyHistogram:                  getEmptyHistogramMetric(emptyHistogram),
+		emptySummary:                    getEmptySummaryMetric(emptySummary),
+		emptyCumulativeSum:              getEmptyCumulativeSumMetric(emptyCumulativeSum),
+		emptyCumulativeHistogram:        getEmptyCumulativeHistogramMetric(emptyCumulativeHistogram),
+		metricWithInvalidTranslatedName: getMetricWithInvalidTranslatedName(),
 	}
 	staleNaNIntGauge       = "staleNaNIntGauge"
 	staleNaNDoubleGauge    = "staleNaNDoubleGauge"
@@ -321,6 +323,19 @@ func getHistogramMetricEmptyDataPoint(name string, attributes pcommon.Map, ts ui
 	return metric
 }
 
+func getMetricWithInvalidTranslatedName() pmetric.Metric {
+	metric := pmetric.NewMetric()
+	metric.SetName("!@#$%^&*()")
+	dp := metric.SetEmptyGauge().DataPoints().AppendEmpty()
+	dp.SetIntValue(10)
+	dp.Attributes().PutStr("label1", "value1")
+	dp.Attributes().PutStr("label2", "value2")
+
+	dp.SetStartTimestamp(pcommon.Timestamp(0))
+	dp.SetTimestamp(pcommon.Timestamp(1000))
+	return metric
+}
+
 func getExpHistogramMetric(
 	name string,
 	attributes pcommon.Map,