prometheusreceiver: disable start time adjustment by default

Author: dashpole

.chloggen/prometheus-remove-starttimeadjustment.yaml

@@ -0,0 +1,30 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: breaking
+
+# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
+component: receiver/prometheus
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: The prometheus receiver no longer adjusts the start time of metrics by default.
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [43656]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext: Disable the receiver.prometheusreceiver.RemoveStartTimeAdjustment |
+    feature gate to temporarily re-enable this functionality. Users that need |
+    this functionality should to migrate to the metricstarttime processor, |
+    and use the true_reset strategy for equivalent behavior.
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: []

receiver/prometheusreceiver/internal/metricfamily_test.go

@@ -120,7 +120,7 @@ func TestMetricGroupData_toDistributionUnitTest(t *testing.T) {
 		intervalStartTimeMs int64
 	}{
 		{
-			name:                "histogram with startTimestamp",
+			name:                "histogram with no startTimestamp",
 			metricName:          "histogram",
 			intervalStartTimeMs: 11,
 			labels:              labels.FromMap(map[string]string{"a": "A", "b": "B"}),
@@ -138,7 +138,6 @@ func TestMetricGroupData_toDistributionUnitTest(t *testing.T) {
 				point.SetTimestamp(pcommon.Timestamp(11 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
 				point.ExplicitBounds().FromRaw([]float64{0.75, 2.75})
 				point.BucketCounts().FromRaw([]uint64{33, 22, 11})
-				point.SetStartTimestamp(pcommon.Timestamp(11 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
 				attributes := point.Attributes()
 				attributes.PutStr("a", "A")
 				attributes.PutStr("b", "B")
@@ -207,7 +206,6 @@ func TestMetricGroupData_toDistributionUnitTest(t *testing.T) {
 				point.SetFlags(pmetric.DefaultDataPointFlags.WithNoRecordedValue(true))
 				point.ExplicitBounds().FromRaw([]float64{0.75, 2.75})
 				point.BucketCounts().FromRaw([]uint64{0, 0, 0})
-				point.SetStartTimestamp(pcommon.Timestamp(11 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
 				attributes := point.Attributes()
 				attributes.PutStr("a", "A")
 				attributes.PutStr("b", "B")
@@ -239,8 +237,7 @@ func TestMetricGroupData_toDistributionUnitTest(t *testing.T) {
 				point := pmetric.NewHistogramDataPoint()
 				point.SetCount(66)
 				point.SetSum(1004.78)
-				point.SetTimestamp(pcommon.Timestamp(11 * time.Millisecond))      // the time in milliseconds -> nanoseconds.
-				point.SetStartTimestamp(pcommon.Timestamp(11 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
+				point.SetTimestamp(pcommon.Timestamp(11 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
 				point.BucketCounts().FromRaw([]uint64{66})
 				attributes := point.Attributes()
 				attributes.PutStr("a", "A")
@@ -323,7 +320,6 @@ func TestMetricGroupData_toNHCBDistributionUnitTest(t *testing.T) {
 				point.SetCount(180)
 				point.SetSum(100.5)
 				point.SetTimestamp(pcommon.Timestamp(11 * time.Millisecond))
-				point.SetStartTimestamp(pcommon.Timestamp(11 * time.Millisecond))
 				point.ExplicitBounds().FromRaw([]float64{1.0, 2.0, 5.0, 10.0})
 				point.BucketCounts().FromRaw([]uint64{10, 25, 45, 50, 50})
 				attributes := point.Attributes()
@@ -347,7 +343,6 @@ func TestMetricGroupData_toNHCBDistributionUnitTest(t *testing.T) {
 				point := pmetric.NewHistogramDataPoint()
 				point.SetTimestamp(pcommon.Timestamp(11 * time.Millisecond))
 				point.SetFlags(pmetric.DefaultDataPointFlags.WithNoRecordedValue(true))
-				point.SetStartTimestamp(pcommon.Timestamp(11 * time.Millisecond))
 				point.ExplicitBounds().FromRaw([]float64{1.0, 2.0, 5.0, 10.0})
 				point.BucketCounts().FromRaw([]uint64{0, 0, 0, 0, 0})
 				attributes := point.Attributes()
@@ -374,7 +369,6 @@ func TestMetricGroupData_toNHCBDistributionUnitTest(t *testing.T) {
 				point.SetCount(50)
 				point.SetSum(125.25)
 				point.SetTimestamp(pcommon.Timestamp(12 * time.Millisecond))
-				point.SetStartTimestamp(pcommon.Timestamp(12 * time.Millisecond))
 				point.ExplicitBounds().FromRaw([]float64{0.5, 2.0})
 				point.BucketCounts().FromRaw([]uint64{15, 20, 15})
 				attributes := point.Attributes()
@@ -400,7 +394,6 @@ func TestMetricGroupData_toNHCBDistributionUnitTest(t *testing.T) {
 				point.SetCount(16)
 				point.SetSum(10.0)
 				point.SetTimestamp(pcommon.Timestamp(30 * time.Millisecond))
-				point.SetStartTimestamp(pcommon.Timestamp(30 * time.Millisecond))
 				point.ExplicitBounds().FromRaw([]float64{-5.0, 0.0, 5.0})
 				point.BucketCounts().FromRaw([]uint64{5, 10, 15, 16})
 				point.Attributes().PutStr("a", "A")
@@ -455,7 +448,7 @@ func TestMetricGroupData_toExponentialDistributionUnitTest(t *testing.T) {
 		intervalStartTimeMs int64
 	}{
 		{
-			name:                "integer histogram with startTimestamp",
+			name:                "integer histogram without startTimestamp",
 			metricName:          "request_duration_seconds",
 			intervalStartTimeMs: 11,
 			labels:              labels.FromMap(map[string]string{"a": "A", "b": "B"}),
@@ -481,8 +474,7 @@ func TestMetricGroupData_toExponentialDistributionUnitTest(t *testing.T) {
 				point := pmetric.NewExponentialHistogramDataPoint()
 				point.SetCount(66)
 				point.SetSum(1004.78)
-				point.SetTimestamp(pcommon.Timestamp(11 * time.Millisecond))      // the time in milliseconds -> nanoseconds.
-				point.SetStartTimestamp(pcommon.Timestamp(11 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
+				point.SetTimestamp(pcommon.Timestamp(11 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
 				point.SetScale(1)
 				point.SetZeroThreshold(0.42)
 				point.SetZeroCount(1)
@@ -560,7 +552,6 @@ func TestMetricGroupData_toExponentialDistributionUnitTest(t *testing.T) {
 				point := pmetric.NewExponentialHistogramDataPoint()
 				point.SetTimestamp(pcommon.Timestamp(11 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
 				point.SetFlags(pmetric.DefaultDataPointFlags.WithNoRecordedValue(true))
-				point.SetStartTimestamp(pcommon.Timestamp(11 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
 				attributes := point.Attributes()
 				attributes.PutStr("a", "A")
 				attributes.PutStr("b", "B")
@@ -704,8 +695,7 @@ func TestMetricGroupData_toSummaryUnitTest(t *testing.T) {
 				qn99 := qtL.AppendEmpty()
 				qn99.SetQuantile(.99)
 				qn99.SetValue(82)
-				point.SetTimestamp(pcommon.Timestamp(14 * time.Millisecond))      // the time in milliseconds -> nanoseconds.
-				point.SetStartTimestamp(pcommon.Timestamp(14 * time.Millisecond)) // the time in milliseconds -> nanoseconds
+				point.SetTimestamp(pcommon.Timestamp(14 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
 				attributes := point.Attributes()
 				attributes.PutStr("a", "A")
 				attributes.PutStr("b", "B")
@@ -848,8 +838,7 @@ func TestMetricGroupData_toSummaryUnitTest(t *testing.T) {
 				qn99 := qtL.AppendEmpty()
 				qn99.SetQuantile(.99)
 				qn99.SetValue(0)
-				point.SetTimestamp(pcommon.Timestamp(14 * time.Millisecond))      // the time in milliseconds -> nanoseconds.
-				point.SetStartTimestamp(pcommon.Timestamp(14 * time.Millisecond)) // the time in milliseconds -> nanoseconds
+				point.SetTimestamp(pcommon.Timestamp(14 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
 				attributes := point.Attributes()
 				attributes.PutStr("a", "A")
 				attributes.PutStr("b", "B")
@@ -942,7 +931,6 @@ func TestMetricGroupData_toNumberDataUnitTest(t *testing.T) {
 
 				// the time in milliseconds -> nanoseconds.
 				point.SetTimestamp(pcommon.Timestamp(13 * time.Millisecond))
-				point.SetStartTimestamp(pcommon.Timestamp(13 * time.Millisecond))
 
 				attributes := point.Attributes()
 				attributes.PutStr("a", "A")
@@ -984,8 +972,7 @@ func TestMetricGroupData_toNumberDataUnitTest(t *testing.T) {
 			want: func() pmetric.NumberDataPoint {
 				point := pmetric.NewNumberDataPoint()
 				point.SetDoubleValue(33.7)
-				point.SetTimestamp(pcommon.Timestamp(13 * time.Millisecond))      // the time in milliseconds -> nanoseconds.
-				point.SetStartTimestamp(pcommon.Timestamp(13 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
+				point.SetTimestamp(pcommon.Timestamp(13 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
 				attributes := point.Attributes()
 				attributes.PutStr("a", "A")
 				attributes.PutStr("b", "B")
@@ -1003,8 +990,7 @@ func TestMetricGroupData_toNumberDataUnitTest(t *testing.T) {
 			want: func() pmetric.NumberDataPoint {
 				point := pmetric.NewNumberDataPoint()
 				point.SetDoubleValue(99.9)
-				point.SetTimestamp(pcommon.Timestamp(28 * time.Millisecond))      // the time in milliseconds -> nanoseconds.
-				point.SetStartTimestamp(pcommon.Timestamp(28 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
+				point.SetTimestamp(pcommon.Timestamp(28 * time.Millisecond)) // the time in milliseconds -> nanoseconds.
 				attributes := point.Attributes()
 				attributes.PutStr("a", "A")
 				attributes.PutStr("b", "B")

receiver/prometheusreceiver/internal/metrics_adjuster_test.go

@@ -8,6 +8,8 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"go.opentelemetry.io/collector/featuregate"
 	"go.opentelemetry.io/collector/pdata/pcommon"
 	"go.opentelemetry.io/collector/pdata/pmetric"
 	semconv "go.opentelemetry.io/otel/semconv/v1.27.0"
@@ -740,6 +742,11 @@ type metricsAdjusterTest struct {
 func runScript(t *testing.T, ma MetricsAdjuster, job, instance string, tests []*metricsAdjusterTest) {
 	for _, test := range tests {
 		t.Run(test.description, func(t *testing.T) {
+			err := featuregate.GlobalRegistry().Set("receiver.prometheusreceiver.RemoveStartTimeAdjustment", false)
+			require.NoError(t, err)
+			defer func() {
+				_ = featuregate.GlobalRegistry().Set("receiver.prometheusreceiver.RemoveStartTimeAdjustment", true)
+			}()
 			adjusted := pmetric.NewMetrics()
 			test.metrics.CopyTo(adjusted)
 			// Add the instance/job to the input metrics if they aren't already present.

receiver/prometheusreceiver/internal/starttimemetricadjuster_test.go

@@ -167,6 +167,7 @@ func TestStartTimeMetricMatch(t *testing.T) {
 }
 
 func TestStartTimeMetricFallback(t *testing.T) {
+	defer testutil.SetFeatureGateForTest(t, removeStartTimeAdjustment, false)()
 	const startTime = pcommon.Timestamp(123 * 1e9)
 	const currentTime = pcommon.Timestamp(126 * 1e9)
 	mockStartTime := time.Now().Add(-10 * time.Hour)

receiver/prometheusreceiver/internal/transaction.go

@@ -32,7 +32,7 @@ import (
 
 var removeStartTimeAdjustment = featuregate.GlobalRegistry().MustRegister(
 	"receiver.prometheusreceiver.RemoveStartTimeAdjustment",
-	featuregate.StageAlpha,
+	featuregate.StageBeta,
 	featuregate.WithRegisterDescription("When enabled, the Prometheus receiver will"+
 		" leave the start time unset. Use the new metricstarttime processor instead."),
 )