[chore] lint test fixes (#43933)

Swap args in assertions.

Signed-off-by: alex boten <[email protected]>

Author: codeboten

connector/routingconnector/metrics_test.go

@@ -328,7 +328,7 @@ func TestMetricsAreCorrectlyMatchOnceWithOTTL(t *testing.T) {
 		rmetric := defaultSink.AllMetrics()[0].ResourceMetrics().At(0)
 		attr, ok := rmetric.Resource().Attributes().Get("value")
 		assert.True(t, ok, "routing attribute must exist")
-		assert.Equal(t, attr.Double(), float64(-1.0))
+		assert.Equal(t, float64(-1.0), attr.Double())
 	})
 
 	t.Run("metric matched by one expression, multiple pipelines", func(t *testing.T) {

receiver/hostmetricsreceiver/internal/scraper/memoryscraper/memory_scraper_test.go

@@ -132,7 +132,7 @@ func TestScrape(t *testing.T) {
 					memUsageIdx = i
 				}
 			}
-			assert.NotEqual(t, memUsageIdx, -1)
+			assert.NotEqual(t, -1, memUsageIdx)
 			assertMemoryUsageMetricValid(t, metrics.At(memUsageIdx), "system.memory.usage")
 
 			if runtime.GOOS == "linux" {

receiver/jmxreceiver/internal/subprocess/integration_test.go

@@ -60,7 +60,7 @@ func prepareSubprocess(conf *Config) (*Subprocess, func(t *assert.CollectT) *pro
 
 	findProcessInfo := func(t *assert.CollectT) *process.Process {
 		pid := int32(subprocess.Pid())
-		assert.NotEqual(t, pid, -1)
+		assert.NotEqual(t, -1, pid)
 		proc, err := process.NewProcess(pid)
 		require.NoError(t, err)
 		ppid, err := proc.Ppid()