misc review comments

Signed-off-by: Stephan Renatus <[email protected]>

Author: srenatus

v1/rego/compile/compile.go

@@ -175,7 +175,7 @@ func (c *Compile) timer(t string) minimetrics {
 	return n
 }
 
-// Prepare evaluates as much as possible without known the (known) input yet
+// Prepare evaluates as much as possible without knowing the (known) input yet
 func (c *Compile) Prepare(ctx context.Context, po ...PrepareOption) (*Prepared, error) {
 	p := &Prepared{
 		compile: c,

v1/server/failtracer/failtracer.go

@@ -59,6 +59,10 @@ func (b *failTracer) Hints(unknowns []*ast.Term) []Hint {
 	seenRefs := map[string]struct{}{}
 	candidates := make([]string, 0, len(unknowns))
 	for i := range unknowns {
+		ref, ok := unknowns[i].Value.(ast.Ref)
+		if !ok || len(ref) < 2 {
+			continue
+		}
 		candidates = append(candidates, string(unknowns[i].Value.(ast.Ref)[1].Value.(ast.String)))
 	}
 
@@ -91,13 +95,11 @@ func (b *failTracer) Hints(unknowns []*ast.Term) []Hint {
 		closestStrings := levenshtein.ClosestStrings(maxDistanceForHint, miss, slices.Values(candidates))
 		proposals := make([]ast.Ref, len(closestStrings))
 		for i := range closestStrings {
-			if len(ref) >= 1 {
-				prop := make([]*ast.Term, 2, len(ref))
-				prop[0] = ast.InputRootDocument
-				prop[1] = ast.StringTerm(closestStrings[i])
-				prop = append(prop, ref[2:]...)
-				proposals[i] = prop
-			}
+			prop := make([]*ast.Term, 2, len(ref))
+			prop[0] = ast.InputRootDocument
+			prop[1] = ast.StringTerm(closestStrings[i])
+			prop = append(prop, ref[2:]...)
+			proposals[i] = prop
 		}
 		var msg string
 		switch len(proposals) {

v1/server/failtracer/hints_test.go

@@ -38,6 +38,14 @@ func TestHints(t *testing.T) {
 				{Message: "input.fruit.price undefined, did you mean input.fruits.price?"},
 			},
 		},
+		{
+			note: "all of input unknown, ignored",
+			evts: []topdown.Event{
+				evtFromExpr(`__local1__ = input.fruit.price`),
+			},
+			unknowns: []string{"input"},
+			exp:      nil,
+		},
 		{
 			note: "simple typo, short ref",
 			evts: []topdown.Event{

v1/server/server.go

@@ -1050,7 +1050,7 @@ func getRevisions(ctx context.Context, store storage.Store, txn storage.Transact
 	return br, nil
 }
 
-func (s *Server) reload(ctx context.Context, txn storage.Transaction, evt storage.TriggerEvent) {
+func (s *Server) reload(_ context.Context, _ storage.Transaction, evt storage.TriggerEvent) {
 	// NOTE(tsandall): We currently rely on the storage txn to provide
 	// critical sections in the server.
 	//