surveys: add submissions view (fixes #9353) #9387
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| forkJoin([ | ||
| receiveData('exams', 'surveys'), | ||
| receiveData('submissions', 'survey'), | ||
| this.couchService.findAll('courses') | ||
| ]).subscribe(([ allSurveys, submissions, courses ]: any) => { | ||
| this.couchService.get('submissions/_design/surveyData/_view/submissionCounts?group=true'), | ||
| this.couchService.findAll('courses'), | ||
| this.couchService.get('submissions/_design/surveyData/_view/parentSurveys') |
There was a problem hiding this comment.
The new forkJoin now depends on two raw couchService.get view calls. get rethrows on 403/404, so if the new surveyData design doc is missing or the user lacks view access, the request errors and forkJoin never reaches the code that stops the loading spinner or populates the table. Previously this path used findAll('submissions', 'survey'), which returned an empty array on errors, so the UI degraded gracefully. Please add error handling/fallback for these view requests to avoid leaving the component stuck when the view is unavailable.
Useful? React with 👍 / 👎.
Fixes #9353