src/app/validators/custom-validators.ts (fixes #9358) #9361
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| static requiredMarkdown(ac: AbstractControl<{ text: string }>): ValidationErrors | null { | ||
| // Markdown editors provide a value object with a text property; coerce to a string control for reuse. | ||
| return CustomValidators.required(new FormControl<string | null>(ac.value?.text ?? '')); |
There was a problem hiding this comment.
Markdown form controls without an imageGroup emit plain strings (PlanetMarkdownTextbox defaults to a string when imageGroup is undefined), but requiredMarkdown now reads only ac.value?.text. For those controls (e.g., the team report dialog’s description markdown field), the validator always feeds '' into required, so even non-empty string content is marked {required: true} and the form stays invalid. The validator should fall back to the raw string value when no text property exists.
Useful? React with 👍 / 👎.
fixes #9358
Codex Task