Skip to content

Conversation

@Saby-Bishops
Copy link
Member

Summary

  • replace untyped dialog form helpers with typed form builder primitives
  • introduce shared dialog field and form control typings for safer reuse

Testing

  • npm run lint (fails: sh: 1: ng: not found)

https://chatgpt.com/codex/tasks/task_e_690ba1fe2648832dabbc048eab8c9187

@Saby-Bishops Saby-Bishops marked this pull request as ready for review November 21, 2025 21:07
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +124 to +126
dialogRef.componentInstance.modalForm = formGroup instanceof FormGroup
? formGroup
: this.fb.group(formGroup);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve untyped dialog forms in confirm

DialogsFormService.confirm now only accepts typed FormGroup instances, so callers that pass an UntypedFormGroup (e.g., PlanetRatingComponent uses popupForm) fall through to this.fb.group(formGroup), which reinterprets the existing form instance as a control config. FormBuilder then builds a new group from the form’s own properties instead of using the provided controls, dropping validators/state and yielding a malformed dialog form—a regression from the previous instanceof UntypedFormGroup guard for untyped forms.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants