Skip to content

Commit 3da57e4

Browse files
authored
Merge pull request #129 from toddbaert/feat/remove-xformation
Remove context transformation, ref in provider hooks
2 parents b3a0cc6 + 86cd353 commit 3da57e4

File tree

3 files changed

+1
-16
lines changed

3 files changed

+1
-16
lines changed

specification.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -177,13 +177,6 @@
177177
"RFC 2119 keyword": "MUST",
178178
"children": []
179179
},
180-
{
181-
"id": "Requirement 1.6.1",
182-
"machine_id": "requirement_1_6_1",
183-
"content": "The `client` SHOULD transform the `evaluation context` using the `provider's` `context transformer` function if one is defined, before passing the result of the transformation to the provider's flag resolution functions.",
184-
"RFC 2119 keyword": "SHOULD",
185-
"children": []
186-
},
187180
{
188181
"id": "Requirement 2.1",
189182
"machine_id": "requirement_2_1",

specification/sections/01-flag-evaluation.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -218,11 +218,3 @@ It's recommended to provide non-blocking mechanisms for flag evaluation, particu
218218
> The `evaluation options` structure's `hooks` field denotes an ordered collection of hooks that the client **MUST** execute for the respective flag evaluation, in addition to those already configured.
219219
220220
See [hooks](./04-hooks.md) for details.
221-
222-
#### Context Transformation
223-
224-
##### Requirement 1.6.1
225-
226-
> The `client` **SHOULD** transform the `evaluation context` using the `provider's` `context transformer` function if one is defined, before passing the result of the transformation to the provider's flag resolution functions.
227-
228-
See [context transformation](./02-providers.md#context-transformation) for details.

specification/sections/02-providers.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ ResolutionDetails<MyStruct> resolveStructureValue(string flagKey, MyStruct defau
113113

114114
#### Provider hooks
115115

116-
A `provider hook` exposes a mechanism for `providers` to register [`hooks`](./04-hooks.md) to tap into various stages of the flag evaluation lifecycle. As one example, feature flag management systems often need to transform the context structures the user provides.
116+
A `provider hook` exposes a mechanism for `provider authors` to register [`hooks`](./04-hooks.md) to tap into various stages of the flag evaluation lifecycle. These hooks can be used to perform side effects and mutate the context for purposes of the provider. Provider hooks are not configured or controlled by the `application author`.
117117

118118
##### Requirement 2.10
119119

0 commit comments

Comments
 (0)