Skip to content

Commit 839541e

Browse files
fix: test errors
1 parent 25bc79a commit 839541e

File tree

4 files changed

+5
-14
lines changed

4 files changed

+5
-14
lines changed

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,4 @@ tokio = { version = "1.32.0", features = [ "full" ] }
1414
typed-builder = "0.16.1"
1515

1616
[dev-dependencies]
17-
mockall = "0.11.4"
1817
spec = { path = "spec" }

src/api/api.rs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,7 @@ mod tests {
102102
use std::sync::Arc;
103103

104104
use super::*;
105-
use crate::{
106-
provider::{self, *},
107-
EvaluationContextFieldValue, EvaluationReason,
108-
};
109-
use mockall::mock;
105+
use crate::{provider::NoOpProvider, EvaluationContextFieldValue, EvaluationReason};
110106
use spec::spec;
111107

112108
#[spec(
@@ -172,14 +168,14 @@ mod tests {
172168
)]
173169
#[tokio::test]
174170
async fn set_provider_invoke_initialize() {
175-
let mut provider = NoOpProvider::default();
171+
let provider = NoOpProvider::default();
176172

177173
assert_eq!(provider.metadata().name, "No Operation - Default");
178174

179175
let mut api = OpenFeature::default();
180176
api.set_provider(provider).await;
181177

182-
assert_eq!(provider.metadata().name, "No Operation");
178+
assert_eq!(api.provider_metadata().await.name, "No Operation");
183179
}
184180

185181
#[spec(

src/provider/feature_provider.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ use crate::{EvaluationContext, EvaluationResult, StructValue};
55

66
use super::ResolutionDetails;
77

8-
#[cfg(test)]
9-
use mockall::{automock, predicate::*};
10-
118
// ============================================================
129
// FeatureProvider
1310
// ============================================================
@@ -25,7 +22,6 @@ use mockall::{automock, predicate::*};
2522
/// vendor SDK, embed an REST client, or read flags from a local file.
2623
///
2724
/// See the [spec](https://openfeature.dev/specification/sections/providers).
28-
#[cfg_attr(test, automock)]
2925
#[async_trait]
3026
pub trait FeatureProvider: Send + Sync + 'static {
3127
/// The provider MAY define an initialize function which accepts the global evaluation

src/provider/no_op_provider.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ impl FeatureProvider for NoOpProvider {
7878
&self.metadata
7979
}
8080

81-
async fn initialize(&mut self, evaluation_context: &EvaluationContext) {
81+
async fn initialize(&mut self, _evaluation_context: &EvaluationContext) {
8282
self.metadata = ProviderMetadata::new("No Operation");
8383
}
8484

@@ -244,7 +244,7 @@ mod tests {
244244
fn metadata_name() {
245245
let provider = NoOpProvider::default();
246246

247-
assert_eq!(provider.metadata().name, "No Operation");
247+
assert_eq!(provider.metadata().name, "No Operation - Default");
248248
}
249249

250250
#[spec(

0 commit comments

Comments
 (0)